Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(asset): normalize VPCSC config detection #9582

Closed
wants to merge 4 commits into from
Closed

tests(asset): normalize VPCSC config detection #9582

wants to merge 4 commits into from

Conversation

tseaver
Copy link
Contributor

@tseaver tseaver commented Oct 31, 2019

Uses #9581 as a base.

Toward #9580

@tseaver tseaver added testing api: cloudasset Issues related to the Cloud Asset Inventory API. labels Oct 31, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 31, 2019
@tseaver
Copy link
Contributor Author

tseaver commented Nov 5, 2019

This PR is premature, because the use of the GOOGLE_CLOUD_TESTS_IN_VPCSC envvar in the asset system tests is non-standard: it defaults the variable to True, which is against the spec in this doc.

@tseaver tseaver closed this Nov 5, 2019
@tseaver tseaver deleted the 9580-asset-normalize-vpcsc branch November 5, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@crwilcox crwilcox Awaiting requested review from crwilcox

@busunkim96 busunkim96 Awaiting requested review from busunkim96

Assignees
No one assigned
Labels
api: cloudasset Issues related to the Cloud Asset Inventory API. cla: yes This human has signed the Contributor License Agreement. testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tseaver @googlebot