Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(datacatalog): add sample to create an entry group #9584

Merged
merged 2 commits into from
Nov 1, 2019
Merged

feat(datacatalog): add sample to create an entry group #9584

merged 2 commits into from
Nov 1, 2019

Conversation

ricardolsmendes
Copy link
Contributor

Fixes #9583

@ricardolsmendes ricardolsmendes requested a review from a team October 31, 2019 21:48
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Oct 31, 2019
@ricardolsmendes ricardolsmendes changed the title Add sample to create an entry group in Data Catalog Data Catalog: add sample to create an entry group Oct 31, 2019
@ricardolsmendes ricardolsmendes changed the title Data Catalog: add sample to create an entry group feat(datacatalog): add sample to create an entry group Nov 1, 2019
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2019
tswast
tswast requested changes Nov 1, 2019
View reviewed changes
datacatalog/noxfile.py Outdated Show resolved Hide resolved
datacatalog/samples/tests/conftest.py Outdated Show resolved Hide resolved
@tseaver tseaver added the api: datacatalog Issues related to the Data Catalog API. label Nov 1, 2019
@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2019
@tswast
Copy link
Contributor

tswast commented Nov 1, 2019

Test failure: Google Cloud Data Catalog API has not been used in project 1065521786570 before or it is disabled. I'll try to enable it and re-run the tests.

@tswast tswast added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2019
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 1, 2019
@tswast tswast merged commit 5571911 into googleapis:master Nov 1, 2019
@ricardolsmendes ricardolsmendes deleted the add-create-entry-group-sample branch November 2, 2019 22:22
@yoshi-automation yoshi-automation mentioned this pull request Jan 29, 2020
Merged
parthea pushed a commit that referenced this pull request Jun 4, 2023
@ricardolsmendes @tswast
feat(datacatalog): add sample to create an entry group (#9584)
a5e5344 
* feat(datacatalog): add sample to create an entry group

Closes #9583

* feat(datacatalog): add sample to create an entry group

Fix pytest fixtures and synth.py.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tswast tswast tswast approved these changes

@tseaver tseaver tseaver approved these changes

Assignees
No one assigned
Labels
api: datacatalog Issues related to the Data Catalog API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Data Catalog: add sample for creating an entry group
5 participants
@ricardolsmendes @tswast @tseaver @googlebot @yoshi-kokoro