Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(containeranalysis): make google.cloud.devtools a namespace #9606

Merged
merged 3 commits into from
Nov 6, 2019
Merged

fix(containeranalysis): make google.cloud.devtools a namespace #9606

merged 3 commits into from
Nov 6, 2019

Conversation

busunkim96
Copy link
Contributor

For #9510

@busunkim96 busunkim96 added the api: containeranalysis Issues related to the Container Analysis API. label Nov 5, 2019
@busunkim96 busunkim96 requested a review from tseaver November 5, 2019 21:42
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Nov 5, 2019
tseaver
tseaver suggested changes Nov 5, 2019
View reviewed changes
Copy link
Contributor

@tseaver tseaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs an equivalent change in containeranalysis.py, adding google.cloud.devtools to the namespaces variable.

@busunkim96 busunkim96 requested a review from tseaver November 6, 2019 18:43
@busunkim96 busunkim96 merged commit ba3668d into googleapis:master Nov 6, 2019
@yoshi-automation yoshi-automation mentioned this pull request Jan 29, 2020
Merged
parthea pushed a commit that referenced this pull request Oct 21, 2023
@busunkim96
fix(containeranalysis): make google.cloud.devtools a namespace (#9606)
2ce44d2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tseaver tseaver tseaver approved these changes

Assignees
No one assigned
Labels
api: containeranalysis Issues related to the Container Analysis API. cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@busunkim96 @tseaver @googlebot