Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tests(storage): normalize VPCSC configuration in systests. #9616

Merged
merged 1 commit into from
Nov 7, 2019
Merged

tests(storage): normalize VPCSC configuration in systests. #9616

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions storage/tests/system.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,10 +36,10 @@

from test_utils.retry import RetryErrors
from test_utils.system import unique_resource_id
from test_utils.vpcsc_config import vpcsc_config


USER_PROJECT = os.environ.get("GOOGLE_CLOUD_TESTS_USER_PROJECT")
RUNNING_IN_VPCSC = os.getenv("GOOGLE_CLOUD_TESTS_IN_VPCSC", "").lower() == "true"


def _bad_copy(bad_request):
Expand Down Expand Up @@ -641,7 +641,7 @@ def test_upload_gzip_encoded_download_raw(self):


class TestUnicode(unittest.TestCase):
@unittest.skipIf(RUNNING_IN_VPCSC, "Test is not VPCSC compatible.")
@vpcsc_config.skip_if_inside_vpcsc
def test_fetch_object_and_check_content(self):
client = storage.Client()
bucket = client.bucket("storage-library-test-bucket")
Expand Down Expand Up @@ -1380,7 +1380,7 @@ class TestAnonymousClient(unittest.TestCase):

PUBLIC_BUCKET = "gcp-public-data-landsat"

@unittest.skipIf(RUNNING_IN_VPCSC, "Test is not VPCSC compatible.")
@vpcsc_config.skip_if_inside_vpcsc
def test_access_to_public_bucket(self):
anonymous = storage.Client.create_anonymous_client()
bucket = anonymous.bucket(self.PUBLIC_BUCKET)
Expand Down