-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(bigquery): import Mapping from collections.abc not from collections #9826
fix(bigquery): import Mapping from collections.abc not from collections #9826
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
When was the abc module added? If not until 3.x, we still need to account for compatibility with Python 2.7 for a little while longer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Just kicked off the Kokoro CI tests. We can merge, assuming those pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tswast I know you like importing modules, not classes, but this is the canonical approach, anything else will be very unclear.
I believe this update is causing issues with several versions of the BigQuery client class. My images are now throwing:
I see the same in 2.7:
|
@robert-l1 |
FWIW: So far six 1.13.0 is the latest release (https://pypi.org/project/six/) and seems to be sufficient. |
Getting following deprecation warning in Bigquery: