Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs(monitoring): tweak formatting in proto comments (via synth) #9966

Merged
merged 1 commit into from
Dec 12, 2019
Merged

docs(monitoring): tweak formatting in proto comments (via synth) #9966

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions monitoring/google/cloud/monitoring_v3/proto/alert.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -302,8 +302,8 @@ message AlertPolicy {
// conditions.
repeated Condition conditions = 12;

// How to combine the results of multiple conditions
// to determine if an incident should be opened.
// How to combine the results of multiple conditions to determine if an
// incident should be opened.
ConditionCombinerType combiner = 6;

// Whether or not the policy is enabled. On write, the default interpretation
Expand Down
2 changes: 1 addition & 1 deletion monitoring/google/cloud/monitoring_v3/proto/service.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,7 +151,7 @@ message ServiceLevelObjective {
ServiceLevelIndicator service_level_indicator = 3;

// The fraction of service that must be good in order for this objective to be
// met. `0 < goal <= 1`.
// met. `0 < goal <= 0.999`.
double goal = 4;

// The time period over which the objective will be evaluated.
Expand Down
2 changes: 1 addition & 1 deletion monitoring/google/cloud/monitoring_v3/proto/service_pb2.py
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

42 changes: 21 additions & 21 deletions monitoring/google/cloud/monitoring_v3/proto/uptime.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,27 +83,6 @@ message InternalChecker {
State state = 7;
}

// The regions from which an Uptime check can be run.
enum UptimeCheckRegion {
// Default value if no region is specified. Will result in Uptime checks
// running from all regions.
REGION_UNSPECIFIED = 0;

// Allows checks to run from locations within the United States of America.
USA = 1;

// Allows checks to run from locations within the continent of Europe.
EUROPE = 2;

// Allows checks to run from locations within the continent of South
// America.
SOUTH_AMERICA = 3;

// Allows checks to run from locations within the Asia Pacific area (ex:
// Singapore).
ASIA_PACIFIC = 4;
}

// This message configures which resources and services to monitor for
// availability.
message UptimeCheckConfig {
Expand Down Expand Up @@ -304,6 +283,27 @@ message UptimeCheckConfig {
repeated InternalChecker internal_checkers = 14 [deprecated = true];
}

// The regions from which an Uptime check can be run.
enum UptimeCheckRegion {
// Default value if no region is specified. Will result in Uptime checks
// running from all regions.
REGION_UNSPECIFIED = 0;

// Allows checks to run from locations within the United States of America.
USA = 1;

// Allows checks to run from locations within the continent of Europe.
EUROPE = 2;

// Allows checks to run from locations within the continent of South
// America.
SOUTH_AMERICA = 3;

// Allows checks to run from locations within the Asia Pacific area (ex:
// Singapore).
ASIA_PACIFIC = 4;
}

// Contains the region, location, and list of IP
// addresses where checkers in the location run from.
message UptimeCheckIp {
Expand Down
10 changes: 5 additions & 5 deletions monitoring/synth.metadata
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,19 +1,19 @@
{
"updateTime": "2019-11-19T13:28:35.257420Z",
"updateTime": "2019-12-12T13:21:41.023609Z",
"sources": [
{
"generator": {
"name": "artman",
"version": "0.42.1",
"dockerImage": "googleapis/artman@sha256:c773192618c608a7a0415dd95282f841f8e6bcdef7dd760a988c93b77a64bd57"
"version": "0.42.3",
"dockerImage": "googleapis/artman@sha256:feed210b5723c6f524b52ef6d7740a030f2d1a8f7c29a71c5e5b4481ceaad7f5"
}
},
{
"git": {
"name": "googleapis",
"remote": "https://github.com/googleapis/googleapis.git",
"sha": "d8dd7fe8d5304f7bd1c52207703d7f27d5328c5a",
"internalRef": "281088257"
"sha": "19c4589a3cb44b3679f7b3fba88365b3d055d5f8",
"internalRef": "285013366"
}
},
{
Expand Down