Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ci: shared config to use Airlock #1133

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

ci: shared config to use Airlock #1133

wants to merge 9 commits into from

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Dec 20, 2024

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Dec 20, 2024
@suztomo
Fixed outdated checkstyle rules
c08692b 
Failed during checkstyle configuration: cannot initialize module TreeWalker - TreeWalker is not allowed as a parent of LineLength Please review 'Parent Module' section

Change-Id: I4dd3533872c0250959cb4bdcdc8f1858fb407415
@suztomo
Avoid nexus-staging-plugin by default
585fbfc 
Change-Id: I68942e23f895ac236d29618127355bb69bd6a84b
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Dec 20, 2024
@suztomo
Copy link
Member Author

suztomo commented Dec 20, 2024 

[INFO] --- maven-bundle-plugin:5.1.8:manifest (bundle-manifest) @ google-oauth-client ---
Error:  Manifest com.google.oauth-client:google-oauth-client:jar:1.37.0 : ${version}, is not understood. too few arguments, for cmd: version, arguments; [version]
Error:  Error(s) found in manifest configuration

@suztomo
removed unnecessary source plugin execution
cd8aa3e 
I was getting this error after setting the shared config:

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-source-plugin:3.3.1:jar (source-jar) on project google-oauth-client: Presumably you have configured maven-source-plugin to execute twice in your build. You have to configure a classifier for at least one of them.

Change-Id: I1affd2c6172636d17b9070283a64c0e39692190c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
size: l Pull request size is large.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@suztomo