Skip to content

Commit

Permalink
chore: Override the version of protobuf-bom to 4.28.3 in libraries-bo…
Browse files Browse the repository at this point in the history
…m. (#6836)
  • Loading branch information
blakeli0 authored Oct 31, 2024
1 parent 2c49bcf commit 5662b26
Show file tree
Hide file tree
Showing 5 changed files with 21 additions and 2 deletions.
2 changes: 1 addition & 1 deletion libraries-bom-protobuf3/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
<modelVersion>4.0.0</modelVersion>
<groupId>com.google.cloud</groupId>
<artifactId>libraries-bom-protobuf3</artifactId>
<version>0.2.0-SNAPSHOT</version><!-- {x-version-update:libraries-bom-protobuf3:current} -->
<version>26.50.0-SNAPSHOT</version><!-- {x-version-update:libraries-bom:current} -->
<packaging>pom</packaging>

<parent>
Expand Down
11 changes: 11 additions & 0 deletions libraries-bom/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -59,6 +59,17 @@

<dependencyManagement>
<dependencies>
<!-- This section overrides the protobuf version specified in first-party-dependencies. This is to provide customers a bom that includes protobuf-java 4.x.
We will upgrade protobuf-bom in first-party-dependencies once we feel comfortable that most customers would not have conflict with protobuf-java 4.x.
This section has to be specified before first-party-dependencies, please do not move it. -->
<dependency>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-bom</artifactId>
<version>4.28.3</version>
<type>pom</type>
<scope>import</scope>
</dependency>

<!-- first-party-dependencies is part of java-shared-dependencies
BOM in https://github.com/googleapis/sdk-platform-java/blob/main/java-shared-dependencies/first-party-dependencies/pom.xml.
This includes Guava, Protobuf, gRPC, Google Auth Libraries, etc. -->
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -182,6 +182,9 @@ private void printKeyCoreLibraryDependencies(Bom bom) {
.append("- Google Cloud Core: ")
.append(versionlessCoordinatesToVersion.get("com.google.cloud:google-cloud-core"))
.append("\n");
report
.append("If you encounter compatibility issues with protobuf-java 4.x, please update your codebase and dependencies to ensure compatibility. If this is not feasible, use libraries-bom-protobuf3 as a workaround. libraries-bom-protobuf3 includes the same client libraries and library versions as libraries-bom.")
.append("\n");
}

private void printApiReferenceLink() {
Expand Down
6 changes: 6 additions & 0 deletions renovate.json
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,12 @@
"^com.fasterxml.jackson.core"
],
"groupName": "jackson dependencies"
},
{
"matchPackagePatterns": [
"^com.google.protobuf:"
],
"enabled": false
}
],
"semanticCommits": "enabled",
Expand Down
1 change: 0 additions & 1 deletion versions.txt
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,5 @@

google-cloud-bom:0.230.0:0.231.0-SNAPSHOT
libraries-bom:26.49.0:26.50.0-SNAPSHOT
libraries-bom-protobuf3:0.1.0:0.2.0-SNAPSHOT
java-cloud-bom-tests:0.45.0:0.46.0-SNAPSHOT
full-convergence-check:0.48.0:0.49.0-SNAPSHOT

0 comments on commit 5662b26

Please sign in to comment.