Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding TraceUtil interface and its implementation to enable Tracing controls via DatastoreOptions #1431

Merged
merged 16 commits into from
May 8, 2024
Merged

feat: Adding TraceUtil interface and its implementation to enable Tracing controls via DatastoreOptions #1431

merged 16 commits into from
May 8, 2024

Commits on May 3, 2024

  1. Adding OpenTelemetry API pom.xml dependency, DatastoreOptions API cha… 

    …nge and TraceUtil interface
    @jimit-j-shah
    jimit-j-shah committed May 3, 2024
    Configuration menu
    Copy the full SHA
    ff171d7 View commit details
    Browse the repository at this point in the history

  2. Adding EnabledTraceUtil, DisabledTraceUtil and TraceUtilTest 

    - Annotating DatastoreOpenTelemetryOptions to be transient as they're not serializable
    @jimit-j-shah
    jimit-j-shah committed May 3, 2024
    Configuration menu
    Copy the full SHA
    3f1dc1b View commit details
    Browse the repository at this point in the history

  3. Fixing unused dependencies

    @jimit-j-shah
    jimit-j-shah committed May 3, 2024
    Configuration menu
    Copy the full SHA
    1639b92 View commit details
    Browse the repository at this point in the history

  4. Fixing linter issues

    @jimit-j-shah
    jimit-j-shah committed May 3, 2024
    Configuration menu
    Copy the full SHA
    2622810 View commit details
    Browse the repository at this point in the history

  5. Adding google-auth-library-credentials dependency due to https://gith… 

    …ub.com/googleapis/java-datastore/actions/runs/8944472794/job/24571458116?pr=1431
    @jimit-j-shah
    jimit-j-shah committed May 3, 2024
    Configuration menu
    Copy the full SHA
    71ec887 View commit details
    Browse the repository at this point in the history

Commits on May 6, 2024

  1. Code review comments

    @jimit-j-shah
    jimit-j-shah committed May 6, 2024
    Configuration menu
    Copy the full SHA
    f9e0c11 View commit details
    Browse the repository at this point in the history

Commits on May 7, 2024

  1. Code review: fix pom to derive dependency from shared dependency

    @jimit-j-shah
    jimit-j-shah committed May 7, 2024
    Configuration menu
    Copy the full SHA
    cd8ed6a View commit details
    Browse the repository at this point in the history

  2. Code review: s/Firestore/Datastore

    @jimit-j-shah
    jimit-j-shah committed May 7, 2024
    Configuration menu
    Copy the full SHA
    0b682ef View commit details
    Browse the repository at this point in the history

  3. Code review: remove redundant opentelemetryOptions initialization

    @jimit-j-shah
    jimit-j-shah committed May 7, 2024
    Configuration menu
    Copy the full SHA
    376d15c View commit details
    Browse the repository at this point in the history

  4. Code review: block comments and API use annotation

    @jimit-j-shah
    jimit-j-shah committed May 7, 2024
    Configuration menu
    Copy the full SHA
    5c2c263 View commit details
    Browse the repository at this point in the history

  5. Code review: s/Firestore/Datastore

    @jimit-j-shah
    jimit-j-shah committed May 7, 2024
    Configuration menu
    Copy the full SHA
    b05645d View commit details
    Browse the repository at this point in the history

  6. Code review: Test changes

    @jimit-j-shah
    jimit-j-shah committed May 7, 2024
    Configuration menu
    Copy the full SHA
    59dc0ce View commit details
    Browse the repository at this point in the history

  7. Code review: DatastoreOptionsTest

    @jimit-j-shah
    jimit-j-shah committed May 7, 2024
    Configuration menu
    Copy the full SHA
    29e088d View commit details
    Browse the repository at this point in the history

  8. Code review: Method name s/getEnabled/isEnabled

    @jimit-j-shah
    jimit-j-shah committed May 7, 2024
    Configuration menu
    Copy the full SHA
    f46058a View commit details
    Browse the repository at this point in the history

Commits on May 8, 2024

  1. Code review: redundant dependency, s/enable/enabled

    @jimit-j-shah
    jimit-j-shah committed May 8, 2024
    Configuration menu
    Copy the full SHA
    2dcc121 View commit details
    Browse the repository at this point in the history

  2. Code review: reinstating dependency after build failure https://githu… 

    …b.com/googleapis/java-datastore/actions/runs/9006313814/job/24743556228
    @jimit-j-shah
    jimit-j-shah committed May 8, 2024
    Configuration menu
    Copy the full SHA
    33d08d6 View commit details
    Browse the repository at this point in the history