Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
toProto()
method. This eliminates large condition structure. TotoProto()
is package-private for internal use. Package-private is only possible on classes (not interfaces), so I converted the Expr to an abstract class with package-private constructor to avoid customer extending it.?
instead.Object
as parameter.Object
might be of typeExpr
which cannot be passed throughConstant.of(..)
method. Instead we need to short circuit conversion, and simply returnObject
since it is already anExpr
.