Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Default retry settings are too aggressive for Resource Exhausted errors #1685

Closed
amfisher-404 opened this issue Aug 1, 2023 · 0 comments · Fixed by #1686
Closed

Default retry settings are too aggressive for Resource Exhausted errors #1685

amfisher-404 opened this issue Aug 1, 2023 · 0 comments · Fixed by #1686
Labels
api: pubsub Issues related to the googleapis/java-pubsub API.

Comments

@amfisher-404
Copy link
Contributor

With the given initial retry of 0.1 sec, multiplier of 1.3, and max total timeout = 10 minutes, a request failing with ResourceExhausted could retry 33 times, and it will take over 20 attempts before the retry interval is > 30s.

The backoff should be more aggressive for RPCs that could retry ResourceExhausted: currently, this is just Publish.
@product-auto-label product-auto-label bot added the api: pubsub Issues related to the googleapis/java-pubsub API. label Aug 1, 2023
@amfisher-404 amfisher-404 mentioned this issue Aug 1, 2023
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: pubsub Issues related to the googleapis/java-pubsub API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: update Publish retry backoff settings amfisher-404/java-pubsub
1 participant
@amfisher-404