-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: setting up samples_build.yaml (2) #1930
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
Pull request size is small.
api: pubsub
Issues related to the googleapis/java-pubsub API.
samples
Issues that are directly related to samples.
labels
Feb 22, 2024
Current failure
|
.cloudbuild/samples_build.yaml
Outdated
- name: gcr.io/cloud-devrel-public-resources/java8 | ||
entrypoint: echo | ||
args: [ | ||
'Samp[le job succeeded', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: typo in "Samp[le"
michaelpri10
approved these changes
Feb 23, 2024
suztomo
added
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Feb 23, 2024
suztomo
added
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Feb 23, 2024
gcf-owl-bot
bot
removed
the
owlbot:run
Add this label to trigger the Owlbot post processor.
label
Feb 23, 2024
gcf-merge-on-green
bot
removed
the
automerge
Merge the pull request once unit tests and other checks pass.
label
Feb 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: pubsub
Issues related to the googleapis/java-pubsub API.
samples
Issues that are directly related to samples.
size: s
Pull request size is small.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancing the sample_build.yaml gradually. Current status:
Merging this for now as this has good progress itself. We'll address AdminIT in a subsequent pull request.