check stream != null before close

googleapis · Feb 17, 2024 · 5f21c7c · 5f21c7c
1 parent 7765164
commit 5f21c7c
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/...ud-storage/src/main/java/com/google/cloud/storage/GapicUnbufferedReadableByteChannel.java b/...ud-storage/src/main/java/com/google/cloud/storage/GapicUnbufferedReadableByteChannel.java
@@ -144,8 +144,10 @@ public long read(ByteBuffer[] dsts, int offset, int length) throws IOException {
         if (hasRemaining(bfl)) {
           leftovers = bfl;
         } else {
-          stream.close();
-          stream = null;
+          if(stream != null) {
+            stream.close();
+            stream = null;
+          }
         }
       } else {
         complete = true;

diff --git a/google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageImpl.java b/google-cloud-storage/src/main/java/com/google/cloud/storage/GrpcStorageImpl.java
@@ -111,7 +111,6 @@
 import java.util.stream.StreamSupport;
 
 import com.google.storage.v2.stub.GrpcStorageCallableFactory;
-import com.google.storage.v2.stub.GrpcStorageStub;
 import io.grpc.*;
 import io.grpc.protobuf.ProtoUtils;
 import io.grpc.protobuf.lite.ProtoLiteUtils;