feat: add unit test and resolve used undeclared dependencies warnings

googleapis · Jan 6, 2020 · 78ca9a4 · 78ca9a4
1 parent fd3e819
commit 78ca9a4
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 0 deletions.
diff --git a/google-cloud-storage/pom.xml b/google-cloud-storage/pom.xml
@@ -87,6 +87,14 @@
       <groupId>org.threeten</groupId>
       <artifactId>threetenbp</artifactId>
     </dependency>
+    <dependency>
+      <groupId> com.google.api.grpc</groupId>
+      <artifactId>proto-google-cloud-iamcredentials-v1</artifactId>
+    </dependency>
+    <dependency>
+      <groupId>com.google.code.gson</groupId>
+      <artifactId>gson</artifactId>
+    </dependency>
 
     <!-- Test dependencies -->
     <dependency>

diff --git a/google-cloud-storage/src/test/java/com/google/cloud/storage/BucketTest.java b/google-cloud-storage/src/test/java/com/google/cloud/storage/BucketTest.java
@@ -697,6 +697,15 @@ public void testDeleteDefaultAcl() throws Exception {
     assertTrue(bucket.deleteDefaultAcl(User.ofAllAuthenticatedUsers()));
   }
 
+  @Test
+  public void testDisableLifeCycleRule() {
+    expect(storage.getOptions()).andReturn(mockOptions).times(1);
+    expect(storage.disableLifeCycleRule(BUCKET_INFO.getName(), "clientEmail")).andReturn(true);
+    replay(storage);
+    initializeBucket();
+    assertTrue(bucket.disableLifeCycleRule(BUCKET_INFO.getName(), "clientEmail"));
+  }
+
   @Test
   public void testCreateDefaultAcl() throws Exception {
     initializeExpectedBucket(4);

diff --git a/pom.xml b/pom.xml
@@ -135,6 +135,12 @@
         <artifactId>guava</artifactId>
         <version>28.1-android</version>
       </dependency>
+      <dependency>
+        <groupId>com.google.code.gson</groupId>
+        <artifactId>gson</artifactId>
+        <version>2.8.6</version>
+        <scope>compile</scope>
+      </dependency>
 
       <dependency>
         <groupId>org.checkerframework</groupId>
@@ -156,6 +162,12 @@
         <artifactId>google-cloud-iamcredentials</artifactId>
         <version>${google.iamcredentials.version}</version>
       </dependency>
+      <dependency>
+        <groupId> com.google.api.grpc</groupId>
+        <artifactId>proto-google-cloud-iamcredentials-v1</artifactId>
+        <version>${google.iamcredentials.version}</version>
+        <scope>compile</scope>
+      </dependency>
       <dependency>
         <groupId>com.google.protobuf</groupId>
         <artifactId>protobuf-java</artifactId>