Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add skeleton implementation of GrpcStorageImpl#getServiceAccount #1384

Merged
merged 1 commit into from
May 16, 2022
Merged

feat: add skeleton implementation of GrpcStorageImpl#getServiceAccount #1384

merged 1 commit into from
May 16, 2022

Conversation

BenWhitehead
Copy link
Collaborator

  • Add conversion for com.google.storage.v2.ServiceAccount
  • Add property test to ensure round trip decode -> endode -> decode succeeds
  • Add ServiceAccountArbitraryProvider

@BenWhitehead BenWhitehead requested review from a team as code owners May 11, 2022 17:56
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: storage Issues related to the googleapis/java-storage API. labels May 11, 2022
@BenWhitehead
feat: add skeleton implementation of GrpcStorageImpl#getServiceAccount
5185d3a 
* Add conversion for com.google.storage.v2.ServiceAccount
* Add property test to ensure round trip decode -> endode -> decode succeeds
* Add ServiceAccountArbitraryProvider
@BenWhitehead BenWhitehead force-pushed the v2/serviceaccount.get branch from 17372bf to 5185d3a Compare May 16, 2022 17:15
@BenWhitehead BenWhitehead merged commit 96b6330 into feat/grpc-storage May 16, 2022
@BenWhitehead BenWhitehead deleted the v2/serviceaccount.get branch May 16, 2022 22:15
sydney-munro pushed a commit that referenced this pull request Jun 7, 2022
@BenWhitehead @sydney-munro
feat: add skeleton implementation of GrpcStorageImpl#getServiceAccount (
6ef8fa5 
#1384)

* Add conversion for com.google.storage.v2.ServiceAccount
* Add property test to ensure round trip decode -> endode -> decode succeeds
* Add ServiceAccountArbitraryProvider
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sydney-munro sydney-munro sydney-munro approved these changes

Assignees
No one assigned
Labels
api: storage Issues related to the googleapis/java-storage API. size: m Pull request size is medium.
Projects
None yet
Milestone
Storage gRPC implementation
Development

Successfully merging this pull request may close these issues.
2 participants
@BenWhitehead @sydney-munro