Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fix Storage#readAllBytes to allow reading compressed byt… #2330

Merged
merged 2 commits into from
Dec 6, 2023

Conversation

sydney-munro
Copy link
Collaborator

…es (#2304)"

This reverts commit 68b96a9.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@sydney-munro sydney-munro requested a review from a team as a code owner December 5, 2023 23:48
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Dec 5, 2023
@sydney-munro sydney-munro added owlbot:ignore instruct owl-bot to ignore a PR and removed size: l Pull request size is large. labels Dec 5, 2023
@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Dec 5, 2023
…be more robust to retryable errors (#2305)"

This reverts commit 21821da.
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Dec 6, 2023
@sydney-munro sydney-munro added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Dec 6, 2023
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Dec 6, 2023
@gcf-merge-on-green gcf-merge-on-green bot merged commit ff38eb0 into main Dec 6, 2023
19 of 20 checks passed
@gcf-merge-on-green gcf-merge-on-green bot deleted the revert-readallbytes branch December 6, 2023 00:28
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Dec 6, 2023
@sydney-munro sydney-munro changed the title Revert "fix: fix Storage#readAllBytes to allow reading compressed byt… fix: fix Storage#readAllBytes to allow reading compressed byt… Dec 6, 2023
@sydney-munro sydney-munro added the release-please:force-run To run release-please label Dec 6, 2023
@release-please release-please bot removed the release-please:force-run To run release-please label Dec 6, 2023
sydney-munro added a commit that referenced this pull request Dec 6, 2023
…d byt… (#2330)

…es (#2304)"

This reverts commit 68b96a9.

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
- [ ] Make sure to open an issue as a [bug/issue](https://github.com/googleapis/java-storage/issues/new/choose) before writing your code!  That way we can discuss the change, evaluate designs, and agree on the general idea
- [ ] Ensure the tests and linter pass
- [ ] Code coverage does not decrease (if any source code was changed)
- [ ] Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the [samples format](
https://github.com/GoogleCloudPlatform/java-docs-samples/blob/main/SAMPLE_FORMAT.md).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. owlbot:ignore instruct owl-bot to ignore a PR size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants