Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use sdk-platform-java-config to consolidate build configs #2413

Merged
merged 4 commits into from
Feb 16, 2024

Conversation

mpeddada1
Copy link
Contributor

Notable Changes:

  1. Use gcr.io/cloud-devrel-public-resources/graalvm_sdk_platform* docker images for Kokoro GraalVM tests instead of gcr.io/cloud-devrel-kokoro-resources/graalvm*.
  2. Use com.google.cloud:sdk-platform-java-config as the parent which inherits configs from java-shared-config and hosts the google-cloud-shared-dependencies version under the google-cloud-shared-dependencies.version property. This artifact is versioned to be the same as google-cloud-shared-dependencies.
  3. Adjust renovate-bot settings to update docker images when a new version of sdk-platform-java-config is on Maven Central.

Example renovate-bot update PR in google-cloud-java: googleapis/google-cloud-java#10290

@mpeddada1 mpeddada1 requested review from a team as code owners February 14, 2024 16:01
@product-auto-label product-auto-label bot added the size: s Pull request size is small. label Feb 14, 2024
Copy link

Warning: This pull request is touching the following templated files:

  • .kokoro/presubmit/graalvm-native.cfg
  • renovate.json

@product-auto-label product-auto-label bot added the api: storage Issues related to the googleapis/java-storage API. label Feb 14, 2024
Copy link
Collaborator

@sydney-munro sydney-munro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no real issues with the changes. A couple of questions which were also pinged offline. copying here for future reference.

will this continue to trigger all the normal workflows? such as release please etc

also the tickets we are cut during the release train all track shared deps. Will they be cut and unblocked using the same processes with this new dependency

@sydney-munro
Copy link
Collaborator

no real issues with the changes. A couple of questions which were also pinged offline. copying here for future reference.

will this continue to trigger all the normal workflows? such as release please etc

also the tickets we are cut during the release train all track shared deps. Will they be cut and unblocked using the same processes with this new dependency
@mpeddada responded that release workflows will continue but tickets will need to be updated to block and unblock.

@sydney-munro sydney-munro merged commit 1d2064b into main Feb 16, 2024
23 checks passed
@sydney-munro sydney-munro deleted the atomic-graalvm-updates branch February 16, 2024 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. size: s Pull request size is small.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants