-
Notifications
You must be signed in to change notification settings - Fork 77
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update DeleteObject Sample to be clearer on object versioning behavior #2595
Changes from all commits
177042d
2c39a0c
c9136db
8182ee8
03eee03
cb3d16f
1aa81de
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,6 +18,7 @@ | |
|
||
// [START storage_delete_file] | ||
import com.google.cloud.storage.Blob; | ||
import com.google.cloud.storage.BlobId; | ||
import com.google.cloud.storage.Storage; | ||
import com.google.cloud.storage.StorageOptions; | ||
|
||
|
@@ -38,16 +39,19 @@ public static void deleteObject(String projectId, String bucketName, String obje | |
System.out.println("The object " + objectName + " wasn't found in " + bucketName); | ||
return; | ||
} | ||
|
||
// Optional: set a generation-match precondition to avoid potential race | ||
// conditions and data corruptions. The request to upload returns a 412 error if | ||
// the object's generation number does not match your precondition. | ||
Storage.BlobSourceOption precondition = | ||
Storage.BlobSourceOption.generationMatch(blob.getGeneration()); | ||
|
||
storage.delete(bucketName, objectName, precondition); | ||
|
||
System.out.println("Object " + objectName + " was deleted from " + bucketName); | ||
BlobId idWithGeneration = blob.getBlobId(); | ||
// Deletes the blob specified by its id. When the generation is present and non-null it will be | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. I think "when the generation is present" is a little vague, maybe we should specify as "When the generation is present in the BlobId object"? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. rephrased the comments. let me know if that is clearer. |
||
// specified in the request. | ||
// If versioning is enabled on the bucket and the generation is present in the delete request, | ||
// only the version of the object with the matching generation will be deleted. | ||
// If instead you want to delete the current version, the generation should be dropped by | ||
// performing the following. | ||
// BlobId idWithoutGeneration = | ||
// BlobId.of(idWithGeneration.getBucket(), idWithGeneration.getName()); | ||
sydney-munro marked this conversation as resolved.
Show resolved
Hide resolved
|
||
// storage.delete(idWithoutGeneration); | ||
storage.delete(idWithGeneration); | ||
|
||
System.out.println("Object " + objectName + " was permanently deleted from " + bucketName); | ||
} | ||
} | ||
// [END storage_delete_file] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe add a comment on this line like "// The BlobId object has the Generation specified"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i think the variable name is clear on this, no?