Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove storage native image sample in favor of sample hosted in google-cloud-java #2636

Merged
merged 1 commit into from
Aug 5, 2024

Conversation

mpeddada1
Copy link
Contributor

This PR removes the library-specific Storage native image sample in favor of a single sample maintained in https://github.com/googleapis/google-cloud-java/tree/main/java-samples/native-image-sample which serves the same purposes of showcasing how to build a native image for a client library.

Documented externally in https://cloud.google.com/java/docs/compile-native-images#whats_next

@mpeddada1 mpeddada1 requested review from a team as code owners July 12, 2024 20:06
Copy link

Warning: This pull request is touching the following templated files:

  • samples/pom.xml

@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. labels Jul 12, 2024
@BenWhitehead BenWhitehead force-pushed the remove-native-image-sample branch from 9f8fb8b to cd5acc9 Compare August 5, 2024 16:20
@BenWhitehead BenWhitehead merged commit b95ba35 into main Aug 5, 2024
20 of 21 checks passed
@BenWhitehead BenWhitehead deleted the remove-native-image-sample branch August 5, 2024 16:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. samples Issues that are directly related to samples. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants