Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update grpc based ReadObject rpcs to remove race condition between cancellation and message handling #2708

Merged
merged 4 commits into from
Sep 20, 2024
Merged

fix: update grpc based ReadObject rpcs to remove race condition between cancellation and message handling #2708

merged 4 commits into from
Sep 20, 2024

Commits on Sep 16, 2024

  1. fix: update grpc based ReadObject rpcs to remove race condition betwe… 

    …en cancellation and message handling

Update GapicUnbufferedReadableByteChannel to manage the grpc stream itself rather than using the stream iterator provided by gax. This allows us to ensure the cancellation is observed and our draining performs before returning from close().

As a side effect of not using the gax stream iterator, we now must handle stream restarts ourselves. GrpcStorageOptions.ReadObjectResumptionStrategy has been removed entirely, while RetryingDependencies and ResultRetryAlgorithm are now plumbed all the way down to the GapicUnbufferedReadableByteChannel.
    @BenWhitehead
    BenWhitehead committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    4f3fd43 View commit details
    Browse the repository at this point in the history

  2. fix improper exception wrapping and update test config for retry code

    @BenWhitehead
    BenWhitehead committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    5186a80 View commit details
    Browse the repository at this point in the history

  3. fix setting metadata result for either success or failure

    @BenWhitehead
    BenWhitehead committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    b1d4996 View commit details
    Browse the repository at this point in the history

  4. fix comment

    @BenWhitehead
    BenWhitehead committed Sep 16, 2024
    Configuration menu
    Copy the full SHA
    98fea43 View commit details
    Browse the repository at this point in the history