Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: create(Blob) instrumentation #2792

Merged
merged 6 commits into from
Oct 29, 2024
Merged

Conversation

sydney-munro
Copy link
Collaborator

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@sydney-munro sydney-munro requested a review from a team as a code owner October 24, 2024 20:48
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/java-storage API. labels Oct 24, 2024
@sydney-munro sydney-munro changed the title wip create(Blob) instrumentation feat: wip create(Blob) instrumentation Oct 24, 2024
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

still reviewing adding one question; I see it's WIP; are you ready for review?

@sydney-munro
Copy link
Collaborator Author

still reviewing adding one question; I see it's WIP; are you ready for review?

not yet just testing some stuff out as the testbench integration is a pain to sort out locally.

@sydney-munro sydney-munro marked this pull request as draft October 25, 2024 17:44
@sydney-munro sydney-munro marked this pull request as ready for review October 25, 2024 19:56
@sydney-munro sydney-munro changed the title feat: wip create(Blob) instrumentation feat: create(Blob) instrumentation Oct 25, 2024
@sydney-munro sydney-munro added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Oct 25, 2024
Copy link
Member

@frankyn frankyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have couple of comments; but LGTM, approving; feel free to merge after addressing them.

@sydney-munro sydney-munro force-pushed the otel-it-testing branch 2 times, most recently from cc8dc4b to 8e2dc67 Compare October 28, 2024 22:10
@sydney-munro sydney-munro merged commit c0abdf9 into otel-v1-branch Oct 29, 2024
17 checks passed
@sydney-munro sydney-munro deleted the otel-it-testing branch October 29, 2024 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: storage Issues related to the googleapis/java-storage API. kokoro:force-run Add this label to force Kokoro to re-run the tests. size: l Pull request size is large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants