Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: remove support for conversion of *.p12 to *.pem #452

Merged
merged 3 commits into from
Jul 10, 2023
Merged

feat!: remove support for conversion of *.p12 to *.pem #452

merged 3 commits into from
Jul 10, 2023

Conversation

ddelgrosso1
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@ddelgrosso1 ddelgrosso1 added do not merge Indicates a pull request not ready for merge, due to either quality or timing. next major: breaking change this is a change that we should wait to bundle into the next major version labels May 9, 2023
@ddelgrosso1 ddelgrosso1 requested a review from a team as a code owner May 9, 2023 18:19
@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label May 9, 2023
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label May 9, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 9, 2023
@ddelgrosso1
Copy link
Contributor Author

Can go with the next major version (node 14).

@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 7, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 7, 2023
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 28, 2023
@ddelgrosso1 ddelgrosso1 added do not merge Indicates a pull request not ready for merge, due to either quality or timing. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Jun 28, 2023
@ddelgrosso1 ddelgrosso1 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 6, 2023
@ddelgrosso1 ddelgrosso1 mentioned this pull request Jul 6, 2023
Merged
4 tasks
@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 6, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 6, 2023
sofisl
sofisl reviewed Jul 6, 2023
View reviewed changes
src/index.ts Outdated
const privateKey = await getPem(keyFile);
return {privateKey};
throw new ErrorWithCode(
'*.p12 certificates are not supported. ' +
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NB: should we add a version number for when it was last supported?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added.

@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 6, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 6, 2023
@generated-files-bot
Copy link

Warning: This pull request is touching the following templated files:

@ddelgrosso1 ddelgrosso1 added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 6, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 6, 2023
bcoe
bcoe approved these changes Jul 7, 2023
View reviewed changes
Copy link
Contributor

@bcoe bcoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like a great move to me.

Let's just keep an eye out for any customers who bump into issues.

@ddelgrosso1 ddelgrosso1 merged commit 522a96d into googleapis:main Jul 10, 2023
@ddelgrosso1 ddelgrosso1 deleted the remove-p12-pem branch July 10, 2023 19:45
@release-please release-please bot mentioned this pull request Jul 10, 2023
Merged
@sofisl sofisl mentioned this pull request Jul 28, 2023
Merged
@danielbankhead danielbankhead mentioned this pull request Aug 7, 2023
Closed
@ddelgrosso1 ddelgrosso1 mentioned this pull request Aug 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sofisl sofisl sofisl left review comments

@bcoe bcoe bcoe approved these changes

@danielbankhead danielbankhead danielbankhead approved these changes

Assignees
No one assigned
Labels
next major: breaking change this is a change that we should wait to bundle into the next major version size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ddelgrosso1 @bcoe @danielbankhead @sofisl