-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!: remove support for conversion of *.p12 to *.pem #452
Conversation
Can go with the next major version (node 14). |
src/index.ts
Outdated
const privateKey = await getPem(keyFile); | ||
return {privateKey}; | ||
throw new ErrorWithCode( | ||
'*.p12 certificates are not supported. ' + |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NB: should we add a version number for when it was last supported?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added.
32ad6b5
to
d20e8a2
Compare
dc2a5f3
to
4d70c11
Compare
Warning: This pull request is touching the following templated files:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems like a great move to me.
Let's just keep an eye out for any customers who bump into issues.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> 🦕