feat(samples): add remaining featurestore api samples #338

suryaguthikonda · 2022-06-23T15:01:50Z

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
Ensure the tests and linter pass
Code coverage does not decrease (if any source code was changed)
Appropriate docs were updated (if necessary)

Fixes #313

…st.js

snippet-bot · 2022-06-23T15:02:11Z

Here is the summary of changes.

You are about to add 7 region tags.

samples/delete-featurestore-sample.js:33, tag aiplatform_delete_featurestore_sample
samples/get-featurestore-sample.js:32, tag aiplatform_get_featurestore_sample
samples/list-featurestores-async-sample.js:31, tag aiplatform_list_featurestores_async_sample
samples/list-featurestores-sample.js:31, tag aiplatform_list_featurestores_sample
samples/list-featurestores-stream-sample.js:31, tag aiplatform_list_featurestores_stream_sample
samples/update-featurestore-fixed-nodes-sample.js:33, tag aiplatform_update_featurestore_fixed_nodes_sample
samples/update-featurestore-sample.js:34, tag aiplatform_update_featurestore_sample

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

Refresh this comment

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

diemtvu · 2022-06-28T09:32:30Z

samples/get-featurestore-sample.js

+  featurestoreId,
+  location = 'us-central1',
+  apiEndpoint = 'us-central1-aiplatform.googleapis.com',
+  timeout = 300000


Can you change this to 5s. For Get/List, the default timeout is 5s

Made the respective changes.

diemtvu · 2022-06-28T09:32:46Z

samples/list-featurestores-async-sample.js

+  project,
+  location = 'us-central1',
+  apiEndpoint = 'us-central1-aiplatform.googleapis.com',
+  timeout = 300000


Same here, change to 5s

diemtvu · 2022-06-28T09:32:55Z

samples/list-featurestores-sample.js

+  project,
+  location = 'us-central1',
+  apiEndpoint = 'us-central1-aiplatform.googleapis.com',
+  timeout = 300000


diemtvu · 2022-06-28T09:33:07Z

samples/list-featurestores-stream-sample.js

+  project,
+  location = 'us-central1',
+  apiEndpoint = 'us-central1-aiplatform.googleapis.com',
+  timeout = 300000


diemtvu · 2022-06-28T09:33:59Z

samples/update-featurestore-fixed-nodes-sample.js

+  fixedNodeCount = 1,
+  location = 'us-central1',
+  apiEndpoint = 'us-central1-aiplatform.googleapis.com',
+  timeout = 300000


Can you change this to 10min

diemtvu · 2022-06-28T09:34:07Z

samples/update-featurestore-sample.js

+  maxNodeCount = 3,
+  location = 'us-central1',
+  apiEndpoint = 'us-central1-aiplatform.googleapis.com',
+  timeout = 300000


…is#313)

generated-files-bot · 2022-06-28T10:10:15Z

Warning: This pull request is touching the following templated files:

README.md - README.md is managed by synthtool. However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/main/.readme-partials.yaml
samples/README.md - samples/README.md is managed by synthtool. However, a partials file can be used to update the README, e.g.: https://github.com/googleapis/nodejs-storage/blob/main/.readme-partials.yaml

gcf-merge-on-green · 2022-06-30T03:52:12Z

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

This review does not reference the most recent commit, and you are using the secure version of merge-on-green. Please re-review the most recent commit.

gcf-merge-on-green · 2022-07-29T22:24:11Z

Merge-on-green attempted to merge your PR for 6 hours, but it was not mergeable because either one of your required status checks failed, one of your required reviews was not approved, or there is a do not merge label. Learn more about your required status checks here: https://help.github.com/en/github/administering-a-repository/enabling-required-status-checks. You can remove and reapply the label to re-run the bot.

suryaguthikonda and others added 8 commits June 7, 2022 15:54

added create-featurestore-sample.js and create-featurestore-sample.te…

0e4e2fa

…st.js

Merge branch 'googleapis:main' into main

a229958

feat(samples): added createFeaturestore sample (googleapis#313)

a36c0bd

Merge branch 'googleapis:main' into main

84f4ccd

feat(samples): added remaining featurestore samples (googleapis#313)

082a375

removed the extraneous files

8cf4ea3

Merge branch 'googleapis:main' into main

4f7b13d

feat(samples): add remaining featurestore api samples (googleapis#313)

9889e29

suryaguthikonda requested review from a team as code owners June 23, 2022 15:01

product-auto-label bot added the size: l Pull request size is large. label Jun 23, 2022

product-auto-label bot added api: vertex-ai Issues related to the googleapis/nodejs-ai-platform API. samples Issues that are directly related to samples. labels Jun 23, 2022

feat(samples): add remaining featurestore apis samples (googleapis#313)

954349a

diemtvu added kokoro:force-run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 24, 2022

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 24, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 24, 2022

🦉 Updates from OwlBot post-processor

f1fde26

See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md

diemtvu approved these changes Jun 24, 2022

View reviewed changes

diemtvu requested a review from dizcology June 24, 2022 16:23

diemtvu reviewed Jun 28, 2022

View reviewed changes

feat(samples): changed timeout of featurestore apis samples (googleap…

b65cebd

…is#313)

dizcology previously approved these changes Jun 29, 2022

View reviewed changes

diemtvu added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit owlbot:run Add this label to trigger the Owlbot post processor. labels Jun 29, 2022

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jun 29, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 29, 2022

gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jun 30, 2022

junkourata added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 8, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 8, 2022

Merge branch 'main' into featurestore-apis

a0a061c

gkc2104 mentioned this pull request Jul 8, 2022

feat(samples): add all feature samples googleapis/java-aiplatform#980

Merged

4 tasks

junkourata added the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 8, 2022

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Jul 8, 2022

junkourata added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 14, 2022

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 14, 2022

suryaguthikonda and others added 2 commits July 28, 2022 11:12

Merge branch 'main' into featurestore-apis

9d109a4

feat(samples): update featurestore-samples.test.js (googleapis#313)

999dc0a

junkourata added the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 28, 2022

yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Jul 28, 2022

junkourata added the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jul 28, 2022

junkourata removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jul 28, 2022

dizcology approved these changes Jul 29, 2022

View reviewed changes

junkourata added kokoro:run Add this label to force Kokoro to re-run the tests. automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit labels Jul 29, 2022

gcf-merge-on-green bot removed the automerge: exact Summon MOG for automerging, but approvals need to be against the latest commit label Jul 29, 2022

diemtvu added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 2, 2022

gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 2, 2022

junkourata merged commit f136458 into googleapis:main Aug 2, 2022

release-please bot mentioned this pull request Aug 2, 2022

chore(main): release 2.2.0 #348

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(samples): add remaining featurestore api samples #338

feat(samples): add remaining featurestore api samples #338

suryaguthikonda commented Jun 23, 2022

snippet-bot bot commented Jun 23, 2022 •

edited

Loading

diemtvu Jun 28, 2022

suryaguthikonda Jun 28, 2022

diemtvu Jun 28, 2022

diemtvu Jun 28, 2022

diemtvu Jun 28, 2022

diemtvu Jun 28, 2022

diemtvu Jun 28, 2022

generated-files-bot bot commented Jun 28, 2022

gcf-merge-on-green bot commented Jun 30, 2022

gcf-merge-on-green bot commented Jul 29, 2022

feat(samples): add remaining featurestore api samples #338

feat(samples): add remaining featurestore api samples #338

Conversation

suryaguthikonda commented Jun 23, 2022

snippet-bot bot commented Jun 23, 2022 • edited Loading

diemtvu Jun 28, 2022

Choose a reason for hiding this comment

suryaguthikonda Jun 28, 2022

Choose a reason for hiding this comment

diemtvu Jun 28, 2022

Choose a reason for hiding this comment

diemtvu Jun 28, 2022

Choose a reason for hiding this comment

diemtvu Jun 28, 2022

Choose a reason for hiding this comment

diemtvu Jun 28, 2022

Choose a reason for hiding this comment

diemtvu Jun 28, 2022

Choose a reason for hiding this comment

generated-files-bot bot commented Jun 28, 2022

gcf-merge-on-green bot commented Jun 30, 2022

gcf-merge-on-green bot commented Jul 29, 2022

snippet-bot bot commented Jun 23, 2022 •

edited

Loading