fix: force import protobufjs/ext/descriptor package #407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: m
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
product-auto-label
bot
added
size: xl
alvarowolfx
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
| @@ -29,6 +29,9 @@ | |||
| "dependencies": { | |||
| "google-gax": "^4.0.3" | |||
| }, | |||
| "peerDependencies": { | |||
| "protobufjs": "^7.2.4" | |||
There was a problem hiding this comment.
7.2.6 is the latest
| @@ -29,6 +29,9 @@ | |||
| "dependencies": { | |||
| "google-gax": "^4.0.3" | |||
| }, | |||
| "peerDependencies": { | |||
| "protobufjs": "^7.2.4" | |||
There was a problem hiding this comment.
7.2.6 is the latest
alexander-fenster
approved these changes
Jan 22, 2024
|
Merging with system-check test bypassed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are using the
protobufjs/ext/descriptorextension to be able to dynamically load/export protobuf definitions, but this never played nicely with the Typescript compiler and by importing it fromgoogle-gaxmakes it even harder to monkey patch some methods.Same issue was reported on the
protobufjsrepo a while ago a seems like there is solution on fixing for that in the short term.This PR changes things so we import
protobufjsdirectly, add a TS file to manually declare the monkey patched methods and addprotobufjsas a peer dependency.