chore!: drop support for node.js 8 (#554)

googleapis · Mar 26, 2020 · 9f41047 · 9f41047
1 parent 63175e0
commit 9f41047
Show file tree

Hide file tree

Showing 23 changed files with 298 additions and 298 deletions.
diff --git a/.eslintignore b/.eslintignore
@@ -1,5 +1,5 @@
 **/node_modules
-src/**/doc/*
+**/.coverage
 build/
 docs/
 protos/
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -0,0 +1,3 @@
+{
+  "extends": "./node_modules/gts"
+}
diff --git a/.eslintrc.yml b/.eslintrc.yml
diff --git a/.github/workflows/ci.yaml b/.github/workflows/ci.yaml
@@ -9,7 +9,7 @@ jobs:
     runs-on: ubuntu-latest
     strategy:
       matrix:
-        node: [8, 10, 12, 13]
+        node: [10, 12, 13]
     steps:
       - uses: actions/checkout@v2
       - uses: actions/setup-node@v1

diff --git a/.mocharc.js b/.mocharc.js
@@ -11,6 +11,7 @@
 // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
 // See the License for the specific language governing permissions and
 // limitations under the License.
+
 const config = {
   "enable-source-maps": true,
   "throw-deprecation": true,

diff --git a/.prettierignore b/.prettierignore
@@ -1,3 +1,5 @@
-node_modules/*
-samples/node_modules/*
-src/**/doc/*
+**/node_modules
+**/.coverage
+build/
+docs/
+protos/
diff --git a/.prettierrc b/.prettierrc
diff --git a/.prettierrc.js b/.prettierrc.js
@@ -0,0 +1,17 @@
+// Copyright 2020 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+module.exports = {
+  ...require('gts/.prettierrc.json'),
+}
diff --git a/package.json b/package.json
@@ -5,7 +5,7 @@
   "license": "Apache-2.0",
   "author": "Google Inc.",
   "engines": {
-    "node": ">=8.10.0"
+    "node": ">=10"
   },
   "repository": "googleapis/nodejs-common",
   "main": "./build/src/index.js",
@@ -17,10 +17,8 @@
   "scripts": {
     "docs": "compodoc src/",
     "test": "c8 mocha build/test",
-    "posttest": "npm run lint && npm run license-check",
     "prepare": "npm run compile",
     "pretest": "npm run compile",
-    "license-check": "jsgl --local .",
     "compile": "tsc -p .",
     "fix": "gts fix",
     "lint": "gts check",
@@ -33,39 +31,37 @@
   "dependencies": {
     "@google-cloud/projectify": "^2.0.0",
     "@google-cloud/promisify": "^2.0.0",
-    "arrify": "^2.0.0",
-    "duplexify": "^3.6.0",
+    "arrify": "^2.0.1",
+    "duplexify": "^4.1.1",
     "ent": "^2.2.0",
     "extend": "^3.0.2",
-    "google-auth-library": "^5.5.0",
-    "retry-request": "^4.0.0",
-    "teeny-request": "^6.0.0"
+    "google-auth-library": "^5.10.1",
+    "retry-request": "^4.1.1",
+    "teeny-request": "^6.0.3"
   },
   "devDependencies": {
-    "@compodoc/compodoc": "^1.1.9",
+    "@compodoc/compodoc": "^1.1.11",
     "@types/ent": "^2.2.1",
     "@types/extend": "^3.0.1",
-    "@types/mocha": "^7.0.0",
+    "@types/mocha": "^7.0.2",
     "@types/mv": "^2.1.0",
-    "@types/ncp": "^2.0.1",
-    "@types/node": "^11.13.0",
+    "@types/ncp": "^2.0.3",
+    "@types/node": "^12.12.31",
     "@types/proxyquire": "^1.3.28",
-    "@types/request": "^2.48.1",
-    "@types/sinon": "^7.0.10",
+    "@types/request": "^2.48.4",
+    "@types/sinon": "^7.5.2",
     "@types/tmp": "0.1.0",
-    "codecov": "^3.2.0",
-    "gts": "^1.0.0",
-    "ink-docstrap": "^1.3.2",
-    "js-green-licenses": "^1.0.0",
-    "linkinator": "^2.0.0",
-    "mocha": "^7.0.0",
+    "c8": "^7.1.0",
+    "codecov": "^3.6.5",
+    "gts": "^2.0.0-alpha.6",
+    "linkinator": "^2.0.4",
+    "mocha": "^7.1.1",
     "mv": "^2.1.1",
     "ncp": "^2.0.0",
-    "nock": "^12.0.0",
-    "c8": "^7.0.0",
-    "proxyquire": "^2.1.0",
-    "sinon": "^9.0.0",
+    "nock": "^12.0.3",
+    "proxyquire": "^2.1.3",
+    "sinon": "^9.0.1",
     "tmp": "0.1.0",
-    "typescript": "3.6.4"
+    "typescript": "~3.8.3"
   }
 }
diff --git a/samples/quickstart.js b/samples/quickstart.js
@@ -1,17 +1,15 @@
-/*!
- * Copyright 2018 Google LCC. All Rights Reserved.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
+// Copyright 2018 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
 
 console.warn(`no samples available 👎`);
diff --git a/samples/system-test/test.js b/samples/system-test/test.js
@@ -1,17 +1,15 @@
-/*!
- * Copyright 2018 Google LCC. All Rights Reserved.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
+// Copyright 2018 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
 
 console.warn(`no sample tests available 👎`);
diff --git a/src/index.ts b/src/index.ts
@@ -1,18 +1,16 @@
-/*!
- * Copyright 2016 Google Inc. All Rights Reserved.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
+// Copyright 2016 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
 
 export {GoogleAuthOptions} from 'google-auth-library';
 /**

diff --git a/src/operation.ts b/src/operation.ts
@@ -1,18 +1,16 @@
-/*!
- * Copyright 2016 Google Inc. All Rights Reserved.
- *
- * Licensed under the Apache License, Version 2.0 (the "License");
- * you may not use this file except in compliance with the License.
- * You may obtain a copy of the License at
- *
- *      http://www.apache.org/licenses/LICENSE-2.0
- *
- * Unless required by applicable law or agreed to in writing, software
- * distributed under the License is distributed on an "AS IS" BASIS,
- * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
- * See the License for the specific language governing permissions and
- * limitations under the License.
- */
+// Copyright 2016 Google LLC
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//      http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
 
 /*!
  * @module common/operation
@@ -27,7 +25,7 @@ import {
 import {ApiError} from './util';
 import {promisify} from 'util';
 
-// tslint:disable-next-line no-any
+// eslint-disable-next-line @typescript-eslint/no-explicit-any
 export class Operation<T = any> extends ServiceObject<T> {
   completeListeners: number;
   hasActiveListeners: boolean;
@@ -71,7 +69,7 @@ export class Operation<T = any> extends ServiceObject<T> {
       config
     );
 
-    // tslint:disable-next-line:no-any
+    // eslint-disable-next-line @typescript-eslint/no-explicit-any
     config.methods = (config.methods || methods) as any;
     super(config);
     this.completeListeners = 0;