Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

fix(deps): update dependency @google-cloud/common to ^0.25.0 #121

Merged
merged 2 commits into from
Oct 3, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@
"fix": "eslint --fix '**/*.js'"
},
"dependencies": {
"@google-cloud/common": "^0.17.0",
"@google-cloud/common": "^0.25.0",
"@google-cloud/paginator": "^0.1.1",
"@google-cloud/projectify": "^0.3.0",
"@google-cloud/promisify": "^0.3.1",
Expand Down
2 changes: 1 addition & 1 deletion src/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ const Image = require('./image.js');
* });
*/
function Compute(options) {
options = common.util.normalizeArguments(this, options);
options = options || {};

const config = {
baseUrl: 'https://www.googleapis.com/compute/v1',
Expand Down
14 changes: 0 additions & 14 deletions test/index.js
Original file line number Diff line number Diff line change
Expand Up @@ -207,20 +207,6 @@ describe('Compute', function() {
assert(compute instanceof Compute);
});

it('should normalize the arguments', function() {
let normalizeArgumentsCalled = false;
const options = {};

fakeUtil.normalizeArguments = function(context, options_) {
normalizeArgumentsCalled = true;
assert.strictEqual(options_, options);
return options_;
};

new Compute(options);
assert.strictEqual(normalizeArgumentsCalled, true);
});

it('should inherit from Service', function() {
assert(compute instanceof Service);

Expand Down