Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

chore: assert.deelEqual => assert.deepStrictEqual #137

Merged
merged 18 commits into from
Jul 30, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions system-test/compute.js
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ describe('Compute', function() {

assert.strictEqual(metadata.name, AUTOSCALER_NAME);

assert.deepEqual(metadata.autoscalingPolicy, {
assert.deepStrictEqual(metadata.autoscalingPolicy, {
coolDownPeriodSec: 30,
cpuUtilization: {
utilizationTarget: 0.8,
Expand Down Expand Up @@ -305,8 +305,8 @@ describe('Compute', function() {
it('should have opened the correct connections', function(done) {
firewall.getMetadata(function(err, metadata) {
assert.ifError(err);
assert.deepEqual(metadata.allowed, expectedMetadata.allowed);
assert.deepEqual(metadata.sourceRanges, expectedMetadata.sourceRanges);
assert.deepStrictEqual(metadata.allowed, expectedMetadata.allowed);
assert.deepStrictEqual(metadata.sourceRanges, expectedMetadata.sourceRanges);
done();
});
});
Expand Down Expand Up @@ -545,7 +545,7 @@ describe('Compute', function() {

assert.strictEqual(metadata.name, INSTANCE_GROUP_NAME);
assert.strictEqual(metadata.description, OPTIONS.description);
assert.deepEqual(metadata.namedPorts, [
assert.deepStrictEqual(metadata.namedPorts, [
{
name: 'http',
port: 80,
Expand Down Expand Up @@ -612,7 +612,7 @@ describe('Compute', function() {

instanceGroup.getMetadata(function(err, metadata) {
assert.ifError(err);
assert.deepEqual(metadata.namedPorts, [
assert.deepStrictEqual(metadata.namedPorts, [
{
name: 'http',
port: 80,
Expand Down Expand Up @@ -1271,7 +1271,7 @@ describe('Compute', function() {
it('should have enabled HTTP connections', function(done) {
vm.getTags(function(err, tags) {
assert.ifError(err);
assert.deepEqual(tags, ['http-server']);
assert.deepStrictEqual(tags, ['http-server']);
done();
});
});
Expand Down Expand Up @@ -1402,7 +1402,7 @@ describe('Compute', function() {
vm.getMetadata(function(err, metadata) {
assert.ifError(err);

assert.deepEqual(metadata.metadata.items, [
assert.deepStrictEqual(metadata.metadata.items, [
{
key: key,
value: value,
Expand Down
2 changes: 1 addition & 1 deletion test/address.js
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ describe('Address', function() {
assert.strictEqual(calledWith.parent, regionInstance);
assert.strictEqual(calledWith.baseUrl, '/addresses');
assert.strictEqual(calledWith.id, ADDRESS_NAME);
assert.deepEqual(calledWith.methods, {
assert.deepStrictEqual(calledWith.methods, {
create: true,
exists: true,
get: true,
Expand Down
4 changes: 2 additions & 2 deletions test/autoscaler.js
Original file line number Diff line number Diff line change
Expand Up @@ -99,7 +99,7 @@ describe('Autoscaler', function() {
assert.strictEqual(calledWith.baseUrl, '/autoscalers');
assert.strictEqual(calledWith.id, AUTOSCALER_NAME);
assert.strictEqual(calledWith.createMethod, createMethod);
assert.deepEqual(calledWith.methods, {
assert.deepStrictEqual(calledWith.methods, {
create: true,
exists: true,
get: true,
Expand Down Expand Up @@ -188,7 +188,7 @@ describe('Autoscaler', function() {
assert.strictEqual(reqOpts.method, 'PATCH');
assert.strictEqual(reqOpts.uri, '/autoscalers');
assert.strictEqual(reqOpts.json, metadata);
assert.deepEqual(metadata, {
assert.deepStrictEqual(metadata, {
name: autoscaler.name,
zone: ZONE.name,
});
Expand Down
6 changes: 3 additions & 3 deletions test/disk.js
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ var fakeUtil = extend({}, util, {
}

promisified = true;
assert.deepEqual(options.exclude, ['snapshot']);
assert.deepStrictEqual(options.exclude, ['snapshot']);
},
});

Expand Down Expand Up @@ -130,7 +130,7 @@ describe('Disk', function() {
assert.strictEqual(calledWith.parent, zoneInstance);
assert.strictEqual(calledWith.baseUrl, '/disks');
assert.strictEqual(calledWith.id, DISK_NAME);
assert.deepEqual(calledWith.methods, {
assert.deepStrictEqual(calledWith.methods, {
create: true,
exists: true,
get: true,
Expand All @@ -151,7 +151,7 @@ describe('Disk', function() {
disk.request = function(reqOpts) {
assert.strictEqual(reqOpts.method, 'POST');
assert.strictEqual(reqOpts.uri, '/createSnapshot');
assert.deepEqual(reqOpts.json, {name: 'test', a: 'b'});
assert.deepStrictEqual(reqOpts.json, {name: 'test', a: 'b'});
done();
};

Expand Down
6 changes: 3 additions & 3 deletions test/firewall.js
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ describe('Firewall', function() {
});

it('should default to the global network', function() {
assert.deepEqual(firewall.metadata, {network: FIREWALL_NETWORK});
assert.deepStrictEqual(firewall.metadata, {network: FIREWALL_NETWORK});
});

it('should inherit from ServiceObject', function() {
Expand All @@ -98,7 +98,7 @@ describe('Firewall', function() {
assert.strictEqual(calledWith.parent, computeInstance);
assert.strictEqual(calledWith.baseUrl, '/global/firewalls');
assert.strictEqual(calledWith.id, FIREWALL_NAME);
assert.deepEqual(calledWith.methods, {
assert.deepStrictEqual(calledWith.methods, {
create: true,
exists: true,
get: true,
Expand Down Expand Up @@ -187,7 +187,7 @@ describe('Firewall', function() {
assert.strictEqual(reqOpts.method, 'PATCH');
assert.strictEqual(reqOpts.uri, '');
assert.strictEqual(reqOpts.json, metadata);
assert.deepEqual(metadata, {
assert.deepStrictEqual(metadata, {
name: firewall.name,
network: FIREWALL_NETWORK,
});
Expand Down
14 changes: 7 additions & 7 deletions test/health-check.js
Original file line number Diff line number Diff line change
Expand Up @@ -73,7 +73,7 @@ describe('HealthCheck', function() {

assert.strictEqual(calledWith.parent, COMPUTE);
assert.strictEqual(calledWith.id, HEALTH_CHECK_NAME);
assert.deepEqual(calledWith.methods, {
assert.deepStrictEqual(calledWith.methods, {
create: true,
exists: true,
get: true,
Expand Down Expand Up @@ -101,8 +101,8 @@ describe('HealthCheck', function() {

COMPUTE.createHealthCheck = function(name, opts, callback) {
assert.strictEqual(name, NAME);
assert.deepEqual(opts, OPTIONS);
assert.deepEqual(OPTIONS, originalOptions);
assert.deepStrictEqual(opts, OPTIONS);
assert.deepStrictEqual(OPTIONS, originalOptions);
callback(); // done()
};

Expand All @@ -113,7 +113,7 @@ describe('HealthCheck', function() {
var createMethod = healthCheck.calledWith_[0].createMethod;

COMPUTE.createHealthCheck = function(name, opts, callback) {
assert.deepEqual(opts, {});
assert.deepStrictEqual(opts, {});
callback(); // done()
};

Expand Down Expand Up @@ -145,8 +145,8 @@ describe('HealthCheck', function() {

COMPUTE.createHealthCheck = function(name, opts, callback) {
assert.strictEqual(name, NAME);
assert.deepEqual(opts, extend({https: true}, OPTIONS));
assert.deepEqual(OPTIONS, originalOptions);
assert.deepStrictEqual(opts, extend({https: true}, OPTIONS));
assert.deepStrictEqual(OPTIONS, originalOptions);
callback(); // done()
};

Expand All @@ -157,7 +157,7 @@ describe('HealthCheck', function() {
var createMethod = healthCheck.calledWith_[0].createMethod;

COMPUTE.createHealthCheck = function(name, opts, callback) {
assert.deepEqual(opts, {https: true});
assert.deepStrictEqual(opts, {https: true});
callback(); // done()
};

Expand Down
Loading