Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Show proper response structure in vm.getMetadata example #169

Merged

Conversation

pickypg
Copy link
Contributor

@pickypg pickypg commented Oct 2, 2018

This updates the documentation for vm.getMetadata calls to show the
real response structure returned by calls using Promises.

  • Appropriate docs were updated (if necessary)

This updates the documentation for `vm.getMetadata` calls to show the
real response structure returned by calls using `Promise`s.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 2, 2018
@pickypg
Copy link
Contributor Author

pickypg commented Oct 2, 2018

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Oct 2, 2018
src/vm.js Outdated
@@ -227,7 +227,8 @@ function VM(zone, name) {
* // If the callback is omitted, we'll return a Promise.
* //-
* vm.getMetadata().then(function(data) {
* const metadata = data[0];
* const operation = data[0];

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@stephenplusplus stephenplusplus merged commit 9a67aa3 into googleapis:master Oct 2, 2018
@stephenplusplus
Copy link
Contributor

Thank you!

@pickypg pickypg deleted the fix/vm.getMetadata-doc-example branch October 2, 2018 18:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants