This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 113
Show proper response structure in vm.getMetadata example #169
Merged
stephenplusplus
merged 2 commits into
googleapis:master
from
pickypg:fix/vm.getMetadata-doc-example
Oct 2, 2018
Merged
Show proper response structure in vm.getMetadata example #169
stephenplusplus
merged 2 commits into
googleapis:master
from
pickypg:fix/vm.getMetadata-doc-example
Oct 2, 2018
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This updates the documentation for `vm.getMetadata` calls to show the real response structure returned by calls using `Promise`s.
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
googlebot
added
the
cla: no
This human has *not* signed the Contributor License Agreement.
label
Oct 2, 2018
I signed it! |
CLAs look good, thanks! |
googlebot
added
cla: yes
This human has signed the Contributor License Agreement.
and removed
cla: no
This human has *not* signed the Contributor License Agreement.
labels
Oct 2, 2018
stephenplusplus
suggested changes
Oct 2, 2018
src/vm.js
Outdated
@@ -227,7 +227,8 @@ function VM(zone, name) { | |||
* // If the callback is omitted, we'll return a Promise. | |||
* //- | |||
* vm.getMetadata().then(function(data) { | |||
* const metadata = data[0]; | |||
* const operation = data[0]; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
stephenplusplus
approved these changes
Oct 2, 2018
Thank you! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the documentation for
vm.getMetadata
calls to show thereal response structure returned by calls using
Promise
s.