This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
refactor: simplify samples and sample tests #240
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
|
👋 @fhinkel I did a lot of cleaning up in here. I don't know which samples were being used in cloud.google.com, and I want to make sure I didn't remove anything important :) Any ideas on how I can verify I haven't broken anything? |
|
I ran these tests locally against the version of |
fhinkel
approved these changes
Dec 21, 2018
|
Thanks! As long as you didn't delete any region tags, it should be fine. Worst case somebody tries to publish documentation and the job will fail because the samples are not found. |
JustinBeckwith
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
JustinBeckwith
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.