Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Adds getManagedInstances and deleteInstances to InstanceGroupManger API #265

Merged

Conversation

modeswitch
Copy link
Contributor

@modeswitch modeswitch commented Feb 11, 2019

Partially addresses #103.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Feb 11, 2019
@modeswitch
Copy link
Contributor Author

@JustinBeckwith One more for you!

src/instance-group-manager.js Outdated Show resolved Hide resolved
@modeswitch modeswitch changed the title Adds listManagedInstances and deleteInstances to InstanceGroupManger API Adds getManagedInstances and deleteInstances to InstanceGroupManger API Feb 11, 2019
@modeswitch
Copy link
Contributor Author

This is ready for kokoro.

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 11, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 11, 2019
@codecov
Copy link

codecov bot commented Feb 11, 2019

Codecov Report

Merging #265 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #265      +/-   ##
==========================================
+ Coverage   99.13%   99.15%   +0.01%     
==========================================
  Files          20       20              
  Lines        1509     1537      +28     
==========================================
+ Hits         1496     1524      +28     
  Misses         13       13
Impacted Files Coverage Δ
src/instance-group.js 100% <ø> (ø) ⬆️
src/instance-group-manager.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 02223bc...f9c0601. Read the comment docs.

@modeswitch
Copy link
Contributor Author

Thanks @JustinBeckwith!

@modeswitch
Copy link
Contributor Author

I think @stephenplusplus needs to approve as well.

@stephenplusplus stephenplusplus merged commit 81921d9 into googleapis:master Feb 11, 2019
@stephenplusplus
Copy link
Contributor

Thank you, @modeswitch!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants