This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 113
Adds getManagedInstances and deleteInstances to InstanceGroupManger API #265
Merged
stephenplusplus
merged 4 commits into
googleapis:master
from
modeswitch:instance-group-manager#2
Feb 11, 2019
Merged
Adds getManagedInstances and deleteInstances to InstanceGroupManger API #265
stephenplusplus
merged 4 commits into
googleapis:master
from
modeswitch:instance-group-manager#2
Feb 11, 2019
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
This human has signed the Contributor License Agreement.
label
Feb 11, 2019
@JustinBeckwith One more for you! |
stephenplusplus
suggested changes
Feb 11, 2019
modeswitch
changed the title
Adds listManagedInstances and deleteInstances to InstanceGroupManger API
Adds getManagedInstances and deleteInstances to InstanceGroupManger API
Feb 11, 2019
This is ready for kokoro. |
JustinBeckwith
added
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Feb 11, 2019
kokoro-team
removed
the
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
label
Feb 11, 2019
Codecov Report
@@ Coverage Diff @@
## master #265 +/- ##
==========================================
+ Coverage 99.13% 99.15% +0.01%
==========================================
Files 20 20
Lines 1509 1537 +28
==========================================
+ Hits 1496 1524 +28
Misses 13 13
Continue to review full report at Codecov.
|
Thanks @JustinBeckwith! |
JustinBeckwith
approved these changes
Feb 11, 2019
I think @stephenplusplus needs to approve as well. |
stephenplusplus
approved these changes
Feb 11, 2019
Thank you, @modeswitch! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #103.