Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

feat: Adds abandonInstances to InstanceGroupManger API #306

Merged
merged 2 commits into from
May 15, 2019

Conversation

modeswitch
Copy link
Contributor

@modeswitch modeswitch commented May 15, 2019

Fixes #278

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label May 15, 2019
@modeswitch
Copy link
Contributor Author

@JustinBeckwith Another patch for you!

* Updated callbacks in all functions, not just abandonInstances.
* Removed extraneous `self = this`.
@modeswitch
Copy link
Contributor Author

modeswitch commented May 15, 2019

@stephenplusplus Fixed. I also updated the other methods to use fat arrow functions (deleteInstances, getManagedInstances, and resize).

@stephenplusplus
Copy link
Contributor

Nice, thanks!

@modeswitch
Copy link
Contributor Author

@JustinBeckwith I think this is ready for kokoro.

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2019
@JustinBeckwith JustinBeckwith changed the title Adds abandonInstances to InstanceGroupManger API feat: Adds abandonInstances to InstanceGroupManger API May 15, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 15, 2019
@codecov
Copy link

codecov bot commented May 15, 2019

Codecov Report

Merging #306 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
+ Coverage   99.14%   99.14%   +<.01%     
==========================================
  Files          20       20              
  Lines        1517     1522       +5     
==========================================
+ Hits         1504     1509       +5     
  Misses         13       13
Impacted Files Coverage Δ
src/instance-group-manager.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9e9c75...bb2be02. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit c359ce3 into googleapis:master May 15, 2019
@modeswitch modeswitch deleted the issue278 branch May 15, 2019 22:03
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for abandonInstances to instance group managers
5 participants