This repository has been archived by the owner on Jul 13, 2023. It is now read-only.
fix: do not override user-provided options #463
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JustinBeckwith
approved these changes
Jul 9, 2020
| @@ -82,7 +83,13 @@ const Image = require('./image.js'); | |||
| */ | |||
| class Compute extends common.Service { | |||
| constructor(options = {}) { | |||
| options.apiEndpoint = options.apiEndpoint || 'compute.googleapis.com'; | |||
There was a problem hiding this comment.
Oh bother ... guessing this isn't the only place I did that 😬 @stephenplusplus could I trouble you to do a broad search for this pattern in our libs (I use @google/repo to do this) and see where else I biffed it?
Codecov Report
@@ Coverage Diff @@
## master #463 +/- ##
=======================================
Coverage 99.60% 99.60%
=======================================
Files 22 22
Lines 11774 11781 +7
=======================================
+ Hits 11728 11735 +7
Misses 46 46
Continue to review full report at Codecov.
|
JustinBeckwith
added
the
cla: yes
chingor13
pushed a commit
to chingor13/nodejs-compute
that referenced
this pull request
Oct 19, 2021
* Change triggered by none of the following: This git repo (https://github.com/googleapis/nodejs-compute.git) Git repo https://github.com/googleapis/synthtool.git * build: set AUTOSYNTH_MULTIPLE_COMMITS=true for context aware commits (googleapis#422) googleapis@2484e4b commit 2484e4b Author: Benjamin E. Coe <bencoe@google.com> Date: Tue Mar 31 18:42:26 2020 -0700 build: set AUTOSYNTH_MULTIPLE_COMMITS=true for context aware commits (googleapis#422) * docs: document the release schedule we follow (googleapis#454) googleapis/synthtool@6a17abc commit 6a17abc7652e2fe563e1288c6e8c23fc260dda97 Author: Benjamin E. Coe <bencoe@google.com> Date: Mon Mar 23 19:22:34 2020 -0700 docs: document the release schedule we follow (googleapis#454) * fix: do not run node 8 CI (googleapis#456) googleapis/synthtool@1b4cc80 commit 1b4cc80a7aaf164f6241937dd87f3bd1f4149e0c Author: Alexander Fenster <fenster@google.com> Date: Wed Mar 25 08:01:31 2020 -0700 fix: do not run node 8 CI (googleapis#456) * fix: update template files for Node.js libraries (googleapis#463) googleapis/synthtool@9982024 commit 99820243d348191bc9c634f2b48ddf65096285ed Author: Alexander Fenster <fenster@google.com> Date: Tue Mar 31 11:56:27 2020 -0700 fix: update template files for Node.js libraries (googleapis#463)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #460