Skip to content
This repository has been archived by the owner on Jul 13, 2023. It is now read-only.

Fix quickstart code sample #69

Merged
merged 1 commit into from
Apr 27, 2018
Merged

Conversation

fhinkel
Copy link
Contributor

@fhinkel fhinkel commented Apr 27, 2018

Either use correct parameters in callback or use the returned promise.

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@ghost ghost added the cla: yes This human has signed the Contributor License Agreement. label Apr 27, 2018
@googlebot googlebot removed the cla: yes This human has signed the Contributor License Agreement. label Apr 27, 2018
@googlebot
Copy link

☹️ Sorry, but only Googlers may change the label cla: yes.

@stephenplusplus
Copy link
Contributor

Thanks!

@stephenplusplus stephenplusplus merged commit 49d7459 into googleapis:master Apr 27, 2018
@codecov
Copy link

codecov bot commented Apr 27, 2018

Codecov Report

Merging #69 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff          @@
##           master    #69   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          19     19           
  Lines        1583   1583           
=====================================
  Hits         1583   1583

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 887a749...b854609. Read the comment docs.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants