Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update service definitions #2016

Merged
merged 7 commits into from
Mar 15, 2024
Merged

Conversation

MarkDuckworth
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@MarkDuckworth MarkDuckworth requested review from a team as code owners March 14, 2024 18:31
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Mar 14, 2024
@alexander-fenster alexander-fenster added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 14, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 14, 2024
@alexander-fenster alexander-fenster added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 14, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 14, 2024
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: xs Pull request size is extra small. labels Mar 14, 2024
@alexander-fenster alexander-fenster added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 14, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 14, 2024
Copy link

snippet-bot bot commented Mar 14, 2024

No region tags are edited in this PR.

This comment is generated by snippet-bot.
If you find problems with this result, please file an issue at:
https://github.com/googleapis/repo-automation-bots/issues.
To update this comment, add snippet-bot:force-run label or use the checkbox below:

  • Refresh this comment

@product-auto-label product-auto-label bot added size: xl Pull request size is extra large. and removed size: m Pull request size is medium. labels Mar 14, 2024
@alexander-fenster alexander-fenster added the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 14, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Mar 14, 2024
@alexander-fenster alexander-fenster changed the title field_info fix: update service definitions Mar 14, 2024
@ehsannas
Copy link
Contributor

Thanks @alexander-fenster .

@ehsannas ehsannas merged commit ea4b6d0 into main Mar 15, 2024
18 checks passed
@ehsannas ehsannas deleted the markduckworth/update-sh-fixes branch March 15, 2024 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. owl-bot-copy size: xl Pull request size is extra large.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants