Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: request minified json when using the rest fallback #2083

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: request minified json when using the rest fallback #2083

wants to merge 1 commit into from

Conversation

MarkDuckworth
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> 🦕

@MarkDuckworth MarkDuckworth requested review from a team as code owners July 12, 2024 18:38
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: firestore Issues related to the googleapis/nodejs-firestore API. labels Jul 12, 2024
MarkDuckworth
MarkDuckworth commented Jul 12, 2024
View reviewed changes
Copy link
Contributor Author

@MarkDuckworth MarkDuckworth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs update to google-gax when gax supports this feature.

@MarkDuckworth MarkDuckworth added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 12, 2024
@michaelAtCoalesce
Copy link

michaelAtCoalesce commented Oct 16, 2024 •
edited
Loading

this ticket might be related to #2215 and why there is a huge memory spike of 800 megabytes in my situation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
api: firestore Issues related to the googleapis/nodejs-firestore API. do not merge Indicates a pull request not ready for merge, due to either quality or timing. size: xs Pull request size is extra small.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MarkDuckworth @michaelAtCoalesce