-
Notifications
You must be signed in to change notification settings - Fork 149
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Finish TypeScript Migration (BREAKING CHANGE) #510
Conversation
85b6314
to
07a8bff
Compare
@JustinBeckwith / Node team: This PR fails CI with the following errors:
Note that |
877b620
to
2373f67
Compare
This PR finishes the Typescript migration of the Firestore Server SDK. As part of this:
unknown
instead ofany
for the user-facing types (only internally, not in the types we shipped)is
to be able to use TypeScript's typechecking.This is the PR that I am planning on merging, and it's also the PR that I am would like to address all feedback in (to reduce merge conflicts). Since it is not very easy to review, I split this out into a series of PRs that are more tightly scoped:
is
#503 Cleanup: Removeis
The individual PRs are not meant to compile/pass tests. There should not be anything in this larger PR (which should pass CI, fingers crossed) that is not part of the other PRs.
This is fairly low priority, so please take your time to review.
Fixes: b/117464450 and b/119350730