-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Open telemetry integration and span Id fix for nodejs logging library #1497
Merged
Merged
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
265a909
feat: OpenTelemetry integration
608c053
feat: add otel system testing with cloud tracing
54d4991
Add unit testing for otel context
d0be991
Add parseOtelContext test
9b1a5d3
testing entry metadata population
fd8eb30
Add system test suites
e5da43f
remove only mocha test keywords
809b940
Fix lint errors
73de242
fix lint issues
c254669
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 1da8791
Add span end method in system tests
94e5f47
Merge branch 'main' into cindy/spanidfix
cindy-peng 82a89bb
fix gts check
9977f11
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] d2af395
Merge branch 'cindy/spanidfix' of https://github.com/googleapis/nodej…
gcf-owl-bot[bot] cfdff26
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] 5d926fd
Merge branch 'cindy/spanidfix' of https://github.com/googleapis/nodej…
gcf-owl-bot[bot] 20e93c9
Remove comments
24be272
move otel packages to peer dependencies
2620b16
move otel packages to peer dependencies
e63c546
fix system test
7620bb5
Merge branch 'main' into cindy/spanidfix
cindy-peng 91c3d6e
add bitmask for tracesampled flag
7260c2b
fix pack-n-play testing
dfe4202
revert pack-n-play sample configuration
567b953
Make otel api as dependency due to low npm version in kokoro infra
3342bb7
🦉 Updates from OwlBot post-processor
gcf-owl-bot[bot] f4dfbff
fix comments to return value directy
a411e8d
Merge branch 'main' into cindy/spanidfix
cindy-peng c7b4228
Merge branch 'main' into cindy/spanidfix
cindy-peng File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would peerDependency work better here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea there was some back and forth discussions here: #1497 (comment)
Basically system test would fail for now if it is imported as peer dependency since our kokoro runs on NPM 6, which doesn't install peer dependency automatically. JS language team suggested us to import OpenTelemetry/api and re-export it for now to avoid test failure and guarantee compatibility : https://chat.google.com/room/AAAAW_Lho4o/ljx6XogZJMI
Once NPM version in Kokoro infra has upgraded, I can change this to peer dependency again.