fixes to address feedback

googleapis · Feb 14, 2024 · a32b39c · a32b39c
1 parent ab01169
commit a32b39c
Show file tree

Hide file tree

Showing 2 changed files with 17 additions and 2 deletions.
diff --git a/src/codec.ts b/src/codec.ts
@@ -257,7 +257,7 @@ export class PGOid extends WrappedNumber {
   value: string;
   constructor(value: string) {
     super();
-    this.value = value.toString();
+    this.value = value;
   }
   valueOf(): number {
     const num = Number(this.value);

diff --git a/system-test/spanner.ts b/system-test/spanner.ts
@@ -828,7 +828,7 @@ describe('Spanner', () => {
     });
 
     describe('oids', () => {
-      it('POSTGRESQL should read pgOid values', function (done) {
+      it('POSTGRESQL should read non-null pgOid values', function (done) {
         if (IS_EMULATOR_ENABLED) {
           this.skip();
         }
@@ -842,6 +842,21 @@ describe('Spanner', () => {
           done();
         });
       });
+
+      it('POSTGRESQL should read null pgOid values', function (done) {
+        if (IS_EMULATOR_ENABLED) {
+          this.skip();
+        }
+        PG_DATABASE.run('SELECT null::oid', (err, rows) => {
+          assert.ifError(err);
+          let queriedValue = rows[0][0].value;
+          if (rows[0][0].value) {
+            queriedValue = rows[0][0].value.value;
+          }
+          assert.strictEqual(queriedValue, null);
+          done();
+        });
+      });
     });
 
     describe('float64s', () => {