Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

session pool memory leak #1655

Closed
AAAhs opened this issue Jun 26, 2022 · 3 comments · Fixed by #1657
Closed

session pool memory leak #1655

AAAhs opened this issue Jun 26, 2022 · 3 comments · Fixed by #1657
Assignees
@asthamohta
Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@AAAhs
Copy link
Contributor

AAAhs commented Jun 26, 2022

Environment

  • Node.js version: 12.22.6
  • npm version: 6.14.15
  • @google-cloud/spanner version: 6.0.0

Detail

I had investigated a memory leak in a project and found that the leak seems to be in the _getSession mehod of this client library.
image

Then I found that calling Promise.race with a long pending promise may lead to a memory leak. Please see here for details: nodejs/node#17469

I have tried to fix and verify this memory leak in the forked repository:
AAAhs@0554408
@AAAhs AAAhs added priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels Jun 26, 2022
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/nodejs-spanner API. label Jun 26, 2022
@asthamohta
Copy link
Contributor

Thankyou @AAAhs for bringing this to our attention. Great find! Would it be possible to raise a PR from your fork to the nodejs library. If all the tests pass I am happy to merge this change

@AAAhs AAAhs mentioned this issue Jun 30, 2022
Merged
@AAAhs
Copy link
Contributor Author

AAAhs commented Jun 30, 2022

Hi @asthamohta , I've tried to fix it in this PR #1657, hope it would be helpful to solve this issue, all tests are passed, please review it, thanks for your time.

@asthamohta
Copy link
Contributor

Thanks @AAAhs, looks good to me but I would just like the core NodeJs team at google to review it once, that should happen this week. Then we can merge it

gcf-merge-on-green bot pushed a commit that referenced this issue Jul 6, 2022
@AAAhs
fix: call Promise.race without a long pending promise to prevent memo…
768acb6 
…ry leak (#1657)

Fixes #1655 🦕
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@asthamohta asthamohta

Labels
api: spanner Issues related to the googleapis/nodejs-spanner API. priority: p2 Moderately-important priority. Fix may not be included in next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: call Promise.race without a long pending promise to prevent memory leak AAAhs/nodejs-spanner
2 participants
@AAAhs @asthamohta