Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: convert index to es6 class #306

Merged
merged 5 commits into from
Aug 28, 2018
Merged

chore: convert index to es6 class #306

merged 5 commits into from
Aug 28, 2018

Conversation

JustinBeckwith
Copy link
Contributor

Let's wait for #301 to land first.

@JustinBeckwith JustinBeckwith added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 24, 2018
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 24, 2018
@ghost ghost assigned JustinBeckwith Aug 24, 2018
@codecov
Copy link

codecov bot commented Aug 24, 2018

Codecov Report

Merging #306 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #306      +/-   ##
=========================================
- Coverage   99.61%   99.6%   -0.01%     
=========================================
  Files          12      12              
  Lines        1294    1279      -15     
=========================================
- Hits         1289    1274      -15     
  Misses          5       5
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f92b224...3a1a553. Read the comment docs.

@JustinBeckwith
Copy link
Contributor Author

gentle ping @crwilcox @kinwa91

@JustinBeckwith JustinBeckwith removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 28, 2018
@jkwlui
Copy link
Member

jkwlui commented Aug 28, 2018

BREAKING CHANGE: must instantiate with new

@codecov
Copy link

codecov bot commented Aug 28, 2018

Codecov Report

Merging #306 into master will decrease coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #306      +/-   ##
==========================================
- Coverage   99.53%   99.53%   -0.01%     
==========================================
  Files          12       12              
  Lines        1295     1280      -15     
==========================================
- Hits         1289     1274      -15     
  Misses          6        6
Impacted Files Coverage Δ
src/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b7ea29d...ff11313. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 7a8b4c6 into googleapis:master Aug 28, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants