Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix color highlighting in CHANGELOG.md #313

Merged
merged 2 commits into from
Aug 28, 2018
Merged

Fix color highlighting in CHANGELOG.md #313

merged 2 commits into from
Aug 28, 2018

Conversation

WaldoJeffers
Copy link
Contributor

@WaldoJeffers WaldoJeffers commented Aug 28, 2018

Clearly not a very significant PR 😅 The devil is in the detail I guess

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Aug 28, 2018
@WaldoJeffers
Copy link
Contributor Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 28, 2018
@codecov
Copy link

codecov bot commented Aug 28, 2018

Codecov Report

Merging #313 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #313   +/-   ##
=======================================
  Coverage   99.61%   99.61%           
=======================================
  Files          12       12           
  Lines        1294     1294           
=======================================
  Hits         1289     1289           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 884c765...71ee381. Read the comment docs.

@stephenplusplus
Copy link
Contributor

Nice!

@JustinBeckwith can we make manual edits to the CHANGELOG?

@JustinBeckwith
Copy link
Contributor

Yeah I think that should be fine. Thanks for the fix!

@JustinBeckwith JustinBeckwith merged commit 8319574 into googleapis:master Aug 28, 2018
@ghost ghost assigned JustinBeckwith Aug 28, 2018
@WaldoJeffers
Copy link
Contributor Author

You're welcome, it didn't take me too long 😬 Congrats for v2

@WaldoJeffers WaldoJeffers deleted the patch-1 branch August 29, 2018 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants