-
Notifications
You must be signed in to change notification settings - Fork 100
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix color highlighting in CHANGELOG.md #313
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
I signed it! |
CLAs look good, thanks! |
Codecov Report
@@ Coverage Diff @@
## master #313 +/- ##
=======================================
Coverage 99.61% 99.61%
=======================================
Files 12 12
Lines 1294 1294
=======================================
Hits 1289 1289
Misses 5 5 Continue to review full report at Codecov.
|
Nice! @JustinBeckwith can we make manual edits to the CHANGELOG? |
Yeah I think that should be fine. Thanks for the fix! |
You're welcome, it didn't take me too long 😬 Congrats for v2 |
Clearly not a very significant PR 😅 The devil is in the detail I guess
Code coverage does not decrease (if any source code was changed)Appropriate docs were updated (if necessary)