feat(session): add label support #373
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
callmehiphop
commented
Oct 16, 2018
•
callmehiphop
commented
- Tests and linter pass
- Code coverage does not decrease (if any source code was changed)
- Appropriate docs were updated (if necessary)
ghost
assigned 
googlebot
added
the
cla: yes
Codecov Report
@@ Coverage Diff @@
## master #373 +/- ##
==========================================
+ Coverage 99.54% 99.54% +<.01%
==========================================
Files 12 12
Lines 1316 1323 +7
==========================================
+ Hits 1310 1317 +7
Misses 6 6
Continue to review full report at Codecov.
|
stephenplusplus
suggested changes
Oct 16, 2018
src/database.js
Outdated
|
|
||
| if (options.labels) { | ||
| reqOpts.session = {labels: options.labels}; | ||
| delete options.labels; |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
👋 @stephenplusplus would you mind taking another look? |
stephenplusplus
approved these changes
Oct 20, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.