docs(samples): updated samples code to use async await #385
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samples/batch.js
Outdated
| console.error('ERROR:', err); | ||
| }); | ||
| try { | ||
| const data = await transaction.createQueryPartitions(query); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
samples/batch.js
Outdated
| const data = await transaction.createQueryPartitions(query); | ||
| const partitions = data[0]; | ||
| console.log(`Successfully created ${partitions.length} query partitions.`); | ||
| } catch (err) { |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
samples/system-test/spanner.test.js
Outdated
| t.regex(output, /Successfully deleted 5 records/); | ||
| } | ||
| ); | ||
| // // update_data |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
JustinBeckwith
changed the title
JustinBeckwith
added
the
kokoro:force-run
JustinBeckwith
approved these changes
Oct 22, 2018
JustinBeckwith
added
kokoro:force-run
googlebot
added
the
cla: yes
kokoro-team
removed
the
kokoro:force-run
Codecov Report
@@ Coverage Diff @@
## master #385 +/- ##
=========================================
Coverage ? 99.54%
=========================================
Files ? 12
Lines ? 1323
Branches ? 0
=========================================
Hits ? 1317
Misses ? 6
Partials ? 0Continue to review full report at Codecov.
|
ghost
assigned
JustinBeckwith
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
Looks like the system tests are still failin |
|
Yes, working to fix those failure
…On Tue, Oct 23, 2018 at 7:27 AM Justin Beckwith ***@***.***> wrote:
Looks like the system tests are still failin
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#385 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AiYqSN68nVPP-xrKF9Duwe44BG68ZA9eks5unneVgaJpZM4XzSYr>
.
|
JustinBeckwith
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
vijay-qlogic
force-pushed
the
asyncify-samples
branch
from
71ff75d
to
bf32c4c
Compare
JustinBeckwith
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
|
@vijay-qlogic I sent you an invite to the googleapis org. If you accept that, sample and system tests will run automatically on these PRs :) |
|
@JustinBeckwith Yes, I accepted that invitation Thanks!, also enabled 2-factor authentication as well |
vijay-qlogic
force-pushed
the
asyncify-samples
branch
from
2ced6de
to
ea404f2
Compare
JustinBeckwith
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
| @@ -122,7 +119,7 @@ function readWriteTransaction(instanceId, databaseId, projectId) { | |||
| const transferAmount = 200000; | |||
| const minimumAmountToTransfer = 300000; | |||
|
|
|||
| database.runTransaction((err, transaction) => { | |||
| database.runTransaction(async (err, transaction) => { | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes googleapis/google-cloud-node#2869 (it's a good idea to open an issue first for discussion)