Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(samples): convert ava tests to mocha #400

Conversation

nareshqlogic
Copy link
Contributor

@nareshqlogic nareshqlogic commented Oct 25, 2018

Fixes convert all sample tests from ava to mocha (googleapis/google-cloud-node#2865) (it's a good idea to open an issue first for discussion)

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Oct 25, 2018
samples/system-test/quickstart.test.js Outdated Show resolved Hide resolved
samples/system-test/quickstart.test.js Outdated Show resolved Hide resolved
samples/system-test/quickstart.test.js Outdated Show resolved Hide resolved
samples/system-test/quickstart.test.js Outdated Show resolved Hide resolved
samples/system-test/quickstart.test.js Outdated Show resolved Hide resolved
samples/system-test/quickstart.test.js Outdated Show resolved Hide resolved
samples/system-test/spanner.test.js Outdated Show resolved Hide resolved
samples/system-test/spanner.test.js Show resolved Hide resolved
@JustinBeckwith JustinBeckwith changed the title Sample ava to mocha testcases conversion refactor(samples): convert ava tests to mocha Oct 25, 2018
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

samples/system-test/quickstart.test.js Outdated Show resolved Hide resolved
samples/system-test/spanner.test.js Outdated Show resolved Hide resolved
samples/system-test/spanner.test.js Outdated Show resolved Hide resolved
samples/system-test/spanner.test.js Outdated Show resolved Hide resolved
samples/system-test/spanner.test.js Outdated Show resolved Hide resolved
samples/system-test/quickstart.test.js Outdated Show resolved Hide resolved
samples/system-test/quickstart.test.js Outdated Show resolved Hide resolved
samples/system-test/spanner.test.js Outdated Show resolved Hide resolved
samples/system-test/spanner.test.js Outdated Show resolved Hide resolved
samples/system-test/spanner.test.js Outdated Show resolved Hide resolved
samples/system-test/spanner.test.js Outdated Show resolved Hide resolved
@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 2, 2018
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 2, 2018
samples/system-test/quickstart.test.js Outdated Show resolved Hide resolved
samples/system-test/spanner.test.js Outdated Show resolved Hide resolved
@JustinBeckwith JustinBeckwith added cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 12, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 12, 2018
@googlebot
Copy link

We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google.
In order to pass this check, please resolve this problem and have the pull request author add another comment and the bot will run again. If the bot doesn't comment, it means it doesn't think anything has changed.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Nov 13, 2018
@nareshqlogic
Copy link
Contributor Author

Hi @JustinBeckwith ,
I added try/catch while deleting instance and database in before hook otherwise it is getting failed as it is not finding instance. Let me know your view about it.

@JustinBeckwith JustinBeckwith added cla: yes This human has signed the Contributor License Agreement. kokoro:force-run Add this label to force Kokoro to re-run the tests. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Nov 16, 2018
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 16, 2018
@JustinBeckwith JustinBeckwith merged commit d339c54 into googleapis:master Nov 16, 2018
@nareshqlogic nareshqlogic deleted the sample-ava-to-mocha-testcases-conversion branch November 29, 2018 06:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants