chore: improve typescript config and types #417
Conversation
googlebot
added
the
cla: yes
| @@ -479,14 +477,12 @@ describe('codec', () => { | |||
| it('should encode structs', () => { | |||
| const value = codec.Struct.fromJSON({a: 'b', c: 'd'}); | |||
| const encoded = codec.encode(value); | |||
| assert.deepStrictEqual(encoded, ['b', 'd']); | |||
| assert.deepStrictEqual([].concat(encoded.slice()), ['b', 'd']); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
JustinBeckwith
added
the
kokoro:force-run
kokoro-team
removed
the
kokoro:force-run
Co-Authored-By: JustinBeckwith <justin.beckwith@gmail.com>
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
1 similar comment
|
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
googlebot
added
cla: no
JustinBeckwith
added
cla: yes
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) |
| @@ -156,7 +167,7 @@ class Database extends ServiceObject { | |||
| createMethod: (_, options, callback) => { | |||
| return instance.createDatabase(formattedName_, options, callback); | |||
| }, | |||
| }); | |||
| } as {} as ServiceObjectConfig); | |||
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
FYI @googleapis/yoshi-nodejs this is currently busted on master, and this should fix things.