Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(typescript): add types for spanner gapic #487

Merged
merged 1 commit into from
Dec 20, 2018
Merged

chore(typescript): add types for spanner gapic #487

merged 1 commit into from
Dec 20, 2018

Conversation

callmehiphop
Copy link
Contributor

While trying to chip away at improving types, I found myself defining a lot of request/response types and seeing a need for them across multiple files. I thought it might be useful to have definition files for our gapic clients (at least until we start generating them in TypeScript).

@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Dec 20, 2018
@JustinBeckwith
Copy link
Contributor

Wow @callmehiphop, thanks for doing this!

@JustinBeckwith JustinBeckwith merged commit 2b5e5cd into googleapis:master Dec 20, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants