Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(types): enable noImplicitAny in session-pool.ts #508

Merged
merged 14 commits into from
Feb 8, 2019
Merged

refactor(types): enable noImplicitAny in session-pool.ts #508

merged 14 commits into from
Feb 8, 2019

Conversation

josecervino
Copy link

Fixes #<issue_number_goes_here>

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Closed then opened again to make revisions simpler.

josecervino and others added 5 commits January 30, 2019 12:01
* build: ignore googleapis.com in doc link check (#500)

* fix(deps): update dependency google-gax to ^0.24.0 (#501)

* chore(deps): update dependency eslint-config-prettier to v4 (#502)

* refactor(types): session-pool.ts
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Jan 31, 2019
@josecervino
Copy link
Author

I signed it!

@googlebot
Copy link

CLAs look good, thanks!

@googlebot googlebot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Jan 31, 2019
@josecervino
Copy link
Author

Most of the build fails have this error: Config validation failed!. Any idea what this means?

@callmehiphop
Copy link
Contributor

@joecervino I think Kokoro just isn't feeling well today, haha.

src/session-pool.ts Outdated Show resolved Hide resolved
src/session-pool.ts Outdated Show resolved Hide resolved
src/session-pool.ts Outdated Show resolved Hide resolved
src/session-pool.ts Outdated Show resolved Hide resolved
@yoshi-automation yoshi-automation added the 🚨 This issue needs some love. label Feb 7, 2019
@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Feb 8, 2019
@callmehiphop callmehiphop added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 8, 2019
@callmehiphop
Copy link
Contributor

@JustinBeckwith could you fight the cla robot for me?

@JustinBeckwith JustinBeckwith added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 8, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this state. It's up to you to confirm consent of all the commit author(s), set the cla label to yes (if enabled on your project), and then merge this pull request when appropriate.

@googlebot googlebot added cla: no This human has *not* signed the Contributor License Agreement. and removed cla: yes This human has signed the Contributor License Agreement. labels Feb 8, 2019
@JustinBeckwith JustinBeckwith added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Feb 8, 2019
@googlebot
Copy link

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

@JustinBeckwith
Copy link
Contributor

I fought the bot, and the bot won

@callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop merged commit 2d742ea into googleapis:master Feb 8, 2019
@josecervino josecervino deleted the session_pool-noImplicitAny branch February 25, 2019 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement. 🚨 This issue needs some love.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants