fix: error serialization in resumable-upload.ts (#2493)

* fix: use json.stringify in error reporting in resumable-upload

Existing error handling has wrong error serialization with .toString(), that leads to [object Object] error messages.
Example:
 Error: Retry limit exceeded - [object Object]
 at Upload.attemptDelayedRetry (/usr/src/app/node_modules/@google-cloud/storage/build/cjs/src/resumable-upload.js:818:26)

Better solution would be JSON.stringify the error

* linter fixes

* fix tests

* linter fix

---------

Co-authored-by: Denis DelGrosso <ddelgrosso@google.com>

src/resumable-upload.ts

@@ -1231,7 +1231,9 @@ export class Upload extends Writable {
 
         if (retryDelay <= 0) {
           this.destroy(
-            new Error(`Retry total time limit exceeded - ${resp.data}`)
+            new Error(
+              `Retry total time limit exceeded - ${JSON.stringify(resp.data)}`
+            )
           );
           return;
         }
@@ -1252,7 +1254,9 @@ export class Upload extends Writable {
       }
       this.numRetries++;
     } else {
-      this.destroy(new Error('Retry limit exceeded - ' + resp.data));
+      this.destroy(
+        new Error(`Retry limit exceeded - ${JSON.stringify(resp.data)}`)
+      );
     }
   }
 

test/resumable-upload.ts

@@ -1874,7 +1874,7 @@ describe('resumable-upload', () => {
         up.destroy = (err: Error) => {
           assert.strictEqual(
             err.message,
-            `Retry limit exceeded - ${RESP.data}`
+            `Retry limit exceeded - ${JSON.stringify(RESP.data)}`
           );
           done();
         };
@@ -1915,7 +1915,7 @@ describe('resumable-upload', () => {
             assert.strictEqual(up.numRetries, 3);
             assert.strictEqual(
               err.message,
-              `Retry limit exceeded - ${RESP.data}`
+              `Retry limit exceeded - ${JSON.stringify(RESP.data)}`
             );
             done();
           });