Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(deps): update gcs-resumable-upload, remove gitnpm usage #1186

Merged
merged 3 commits into from
May 12, 2020
Merged

fix(deps): update gcs-resumable-upload, remove gitnpm usage #1186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
27122ba
fix(deps): update dependency gcs-resumable-upload to v3
stephenplusplus May 12, 2020
1711285
fix: replace gitnpm.com links with npmjs.com
stephenplusplus May 12, 2020
f9c6922
update bucket.ts
stephenplusplus May 12, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,7 @@
"duplexify": "^3.5.0",
"extend": "^3.0.2",
"gaxios": "^3.0.0",
"gcs-resumable-upload": "^2.2.4",
"gcs-resumable-upload": "^3.0.0",
"hash-stream-validation": "^0.2.2",
"mime": "^2.2.0",
"mime-types": "^2.0.8",
Expand Down
2 changes: 1 addition & 1 deletion src/bucket.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3267,7 +3267,7 @@ class Bucket extends ServiceObject {
* input file is larger than 5 MB.*
*
* For faster crc32c computation, you must manually install
* [`fast-crc32c`](http://www.gitnpm.com/fast-crc32c):
* [`fast-crc32c`](https://www.npmjs.com/package/fast-crc32c):
*
* $ npm install --save fast-crc32c
*
Expand Down
16 changes: 8 additions & 8 deletions src/file.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1122,7 +1122,7 @@ class File extends ServiceObject<File> {
* recourse is to try downloading the file again.
*
* For faster crc32c computation, you must manually install
* [`fast-crc32c`](http://www.gitnpm.com/fast-crc32c):
* [`fast-crc32c`](https://www.npmjs.com/package/fast-crc32c):
*
* $ npm install --save fast-crc32c
*
Expand Down Expand Up @@ -1608,21 +1608,21 @@ class File extends ServiceObject<File> {
* by setting `options.resumable` to `false`.
*
* Resumable uploads require write access to the $HOME directory. Through
* [`config-store`](http://www.gitnpm.com/configstore), some metadata is
* stored. By default, if the directory is not writable, we will fall back to
* a simple upload. However, if you explicitly request a resumable upload, and
* we cannot write to the config directory, we will return a
* [`config-store`](https://www.npmjs.com/package/configstore), some metadata
* is stored. By default, if the directory is not writable, we will fall back
* to a simple upload. However, if you explicitly request a resumable upload,
* and we cannot write to the config directory, we will return a
* `ResumableUploadError`.
*
* <p class="notice">
* There is some overhead when using a resumable upload that can cause
* noticeable performance degradation while uploading a series of small
* files. When uploading files less than 10MB, it is recommended that the
* resumable feature is disabled.
* files. When uploading files less than 10MB, it is recommended that the
* resumable feature is disabled.
* </p>
*
* For faster crc32c computation, you must manually install
* [`fast-crc32c`](http://www.gitnpm.com/fast-crc32c):
* [`fast-crc32c`](https://www.npmjs.com/package/fast-crc32c):
*
* $ npm install --save fast-crc32c
*
Expand Down