test: cleanup kms tests to avoid setting incorrect keys #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: s
ddelgrosso1
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
danielbankhead
approved these changes
Jun 7, 2023
| await bucket.setMetadata({ | ||
| encryption: { | ||
| defaultKmsKeyName: kmsKeyName, | ||
| }, | ||
| }); | ||
| }); | ||
|
|
||
| after(async () => { | ||
| afterEach(async () => { |
There was a problem hiding this comment.
Nice! This is pretty clever
frankyn
approved these changes
Jun 7, 2023
frankyn
reviewed
Jun 7, 2023
| @@ -2551,14 +2551,17 @@ describe('storage', () => { | |||
| before(async () => { | |||
| bucket = storage.bucket(generateName(), {kmsKeyName}); | |||
| await bucket.create(); | |||
| }); | |||
|
|
|||
| beforeEach(async () => { | |||
There was a problem hiding this comment.
I would say try it, but you may hit update bucket metadata request limits due to
There was a problem hiding this comment.
If I start to see throttling problems I will add an artificial delay to the beforeEach / afterEach functions.
ddelgrosso1
added a commit
to ddelgrosso1/nodejs-storage
that referenced
this pull request
Jul 6, 2023
ddelgrosso1
added a commit
to ddelgrosso1/nodejs-storage
that referenced
this pull request
Jul 12, 2023
ddelgrosso1
added a commit
to ddelgrosso1/nodejs-storage
that referenced
this pull request
Jul 24, 2023
ddelgrosso1
added a commit
that referenced
this pull request
Jul 24, 2023
* test: cleanup kms tests to avoid setting incorrect keys (#2213) * chore(deps): update dependency c8 to v8 (#2221) * feat!: better typing for metadata * more metadata typing * fix merge problems * remove extend * fix merge conflicts --------- Co-authored-by: Mend Renovate <renovate@whitesourcesoftware.com>
ddelgrosso1
added a commit
that referenced
this pull request
Jul 24, 2023
* test: cleanup kms tests to avoid setting incorrect keys (#2213) * chore(deps): update dependency c8 to v8 (#2221) * feat!: better typing for metadata * more metadata typing * fix merge problems * remove extend * fix merge conflicts --------- Co-authored-by: Mend Renovate <renovate@whitesourcesoftware.com>
ddelgrosso1
added a commit
that referenced
this pull request
Aug 3, 2023
* refactor!: Remove `extend` and Treat Provided Options as Mutable (#2204) * refactor: Remove `extend` This is the prelimary, `src`-only commit. * fix: object merging * chore: remove log * chore: minor clean-up * chore: more clean-up * refactor: remove `extend` * perf!: treat provided options as mutable * feat!: stronger typing for lifecycle rules (#2215) * fix!: Do not return responsebody in delete, only raw response (#2236) * fix!: Remove extraneous validation in favor of server errors (#2237) * fix!: Remove extraneous validation in favor of server errors * remove test * refactor!: mark bucket.setLabels and associated interfaces as deprecated (#2214) * refactor!: mark bucket.setLabels and associated interfaces as deprecated * update addBucketLabel to use setMetadata * mark getLabels / deleteLabels deprecated, update samples * feat!: disable source maps for smaller bundle size (#2240) * feat!: better typing for metadata (#2234) * test: cleanup kms tests to avoid setting incorrect keys (#2213) * chore(deps): update dependency c8 to v8 (#2221) * feat!: better typing for metadata * more metadata typing * fix merge problems * remove extend * fix merge conflicts --------- Co-authored-by: Mend Renovate <renovate@whitesourcesoftware.com> * chore!: make node 14 the minimum version (#2230) * chore!: make node 14 the minimum version * move conformance test to node 14 * package upgrades, fix unit test compilation * update google owned deps * fix tests * remove node 12 kokoro folders * merge and fix issues * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * export new metadata types from index * fix samples tests * fix system test --------- Co-authored-by: Daniel Bankhead <danielbankhead@google.com> Co-authored-by: Mend Renovate <renovate@whitesourcesoftware.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #2209 🦕